-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable collecting cri-o metrics #4087
Comments
Thanks for reporting! This seems reasonable, we might have to rename the docker-opt/docker-env |
Should probably enable the metrics by default, until we can improve upon the docker-centric situation |
Seems like we forgot all about this one... Should still modify the docker-centric variables. But maybe we can just make i.e. install this, and uncomment the line:
Currently we overwrite this with a custom version: deploy/iso/minikube-iso/package/crio-bin/crio-bin.mk: echo 'CRIO_OPTIONS="--log-level=debug"' > $(TARGET_DIR)/etc/sysconfig/crio And the $CRIO_METRICS_OPTIONS are removed: -ExecStart=/usr/local/bin/crio \
- $CRIO_CONFIG_OPTIONS \
- $CRIO_RUNTIME_OPTIONS \
- $CRIO_STORAGE_OPTIONS \
- $CRIO_NETWORK_OPTIONS \
- $CRIO_METRICS_OPTIONS
+ExecStart=/usr/bin/crio \
+ $CRIO_OPTIONS \
+ $CRIO_MINIKUBE_OPTIONS The custom generated minikube configuration: var (
crioOptsTmpl = `
CRIO_MINIKUBE_OPTIONS='{{ range .EngineOptions.InsecureRegistry }}--insecure-registry {{.}} {{ end }}'
`
crioOptsPath = "/etc/sysconfig/crio.minikube"
) |
Tried to enable this in crio.conf, but it failed (to apply, since the config is being overwritten) |
Fixed now, actually changed in #5970 but stopped being overwritten with #6219 $ grep -C3 metrics /etc/crio/crio.conf
"/opt/cni/bin/",
]
# A necessary configuration for Prometheus based metrics retrieval
[crio.metrics]
# Globally enable or disable metrics support.
enable_metrics = true
# The port on which the metrics server will listen.
metrics_port = 9090
Will be included in |
I can currently run:
minikube start --container-runtime=cri-o
This will start minikube with CRI-O as the container runtime. CRI-O exposes metrics with this flag enabled
--enable-metrics: Enable metrics endpoint. Default is localhost:9090
. I would like to access the metrics exposed here for minikube but this currently isn't possible without additional changes in the VM itself.Would it be possible to allow passing in runtime flags as a feature, at least for all currently supported alternative container runtimes?
The text was updated successfully, but these errors were encountered: