Skip to content

audit: update as of 2021-07-01#2281

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cncf-ci:autoaudit-prow
Jul 2, 2021
Merged

audit: update as of 2021-07-01#2281
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cncf-ci:autoaudit-prow

Conversation

@cncf-ci
Copy link
Copy Markdown
Contributor

@cncf-ci cncf-ci commented Jun 30, 2021

Audit Updates wg-k8s-infra

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 30, 2021

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/audit Audit of project resources, audit followup issues, code in audit/ label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin June 30, 2021 19:38
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2021
@cncf-ci cncf-ci changed the title audit: update as of 2021-06-30 audit: update as of 2021-07-01 Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2021
@cncf-ci cncf-ci force-pushed the autoaudit-prow branch 2 times, most recently from 5482029 to 6332280 Compare July 1, 2021 16:41
spiffxp
spiffxp approved these changes Jul 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/ok-to-test

...s-staging-addon-manager/buckets/artifacts.k8s-staging-addon-manager.appspot.com/logging.json
@@ -0,0 +1 @@
{"logBucket": "k8s-infra-artifacts-gcslogs", "logObjectPrefix": "artifacts.k8s-staging-addon-manager.appspot.com"}
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are expected from deploying #2231 (plus fixup #2283)

audit/projects/k8s-staging-cluster-api-gcp/iam.json
Comment on lines +2 to +31
"auditConfigs": [
{
"auditLogConfigs": [
{
"logType": "ADMIN_READ"
},
{
"logType": "DATA_READ"
},
{
"logType": "DATA_WRITE"
}
],
"service": "iam.googleapis.com"
},
{
"auditLogConfigs": [
{
"logType": "ADMIN_READ"
},
{
"logType": "DATA_READ"
},
{
"logType": "DATA_WRITE"
}
],
"service": "compute.googleapis.com"
}
],
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is me doing something manually: #2147 (comment)

audit/projects/kubernetes-public/secrets/slack-moderator-words-config/versions.json
Comment on lines +2 to +10
{
"createTime": "2021-06-30T17:01:11.914742Z",
"etag": "\"15c5feab6c38f6\"",
"name": "projects/127754664067/secrets/slack-moderator-words-config/versions/4",
"replicationStatus": {
"automatic": {}
},
"state": "ENABLED"
},
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was me fixing the secret: #2013 (comment)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit baa5164 into kubernetes:main Jul 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@spiffxp spiffxp spiffxp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spiffxp spiffxp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

3 participants

@cncf-ci @k8s-ci-robot @spiffxp