infra/gcp/lib_gcs: fix ensure_gcs_bucket_logging#2283
Merged
k8s-ci-robot merged 3 commits intokubernetes:mainfrom Jul 1, 2021
Merged
infra/gcp/lib_gcs: fix ensure_gcs_bucket_logging#2283k8s-ci-robot merged 3 commits intokubernetes:mainfrom
k8s-ci-robot merged 3 commits intokubernetes:mainfrom
Conversation
specifically - copy-pasta / too many args to gsutil logging get - silence diff used to check if logging must be updated
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Contributor
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/S
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
ref: #904 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #2231
I missed the copy-paste in three rounds of review, it took actually running the script for me to notice.
I also quieted down the noise from diff