partial-audit: k8s-infra-* update as of 2021-02-24#1717
partial-audit: k8s-infra-* update as of 2021-02-24#1717k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @cncf-ci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/check-cla |
| "members": [ | ||
| "projectEditor:k8s-infra-e2e-scale-project", | ||
| "projectOwner:k8s-infra-e2e-scale-project" | ||
| "projectEditor:k8s-infra-e2e-gpu-project", |
There was a problem hiding this comment.
why does git see this as a move?
| "labels": { | ||
| "sig": "testing" | ||
| }, |
There was a problem hiding this comment.
note to self for followup: need to decide on a convention for labeling secrets
I've been labeling other secrets in kubernetes-public with e.g. labels.app=slack-infra
I had considered group=sig-testing but feel like sig=testing lines up with "only sigs can own code"
| "group:k8s-infra-prow-oncall@kubernetes.io", | ||
| "user:hh@ii.coop" |
There was a problem hiding this comment.
if we plan on keeping this secret around, my preference would be to replace the user: with a group
longer term we should have audit use a k8s-owned account
| @@ -1 +1 @@ | |||
| prow-build us-central1 us-central1-c;us-central1-f;us-central1-b 67 RUNNING | |||
| prow-build us-central1 us-central1-c;us-central1-f;us-central1-b 72 RUNNING | |||
There was a problem hiding this comment.
nit: we should have audit dump a format that is less noisy for clusters, given that this cluster auto-scales
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cncf-ci, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/check-cla |
Audit Updates wg-k8s-infra