Skip to content

partial-audit: k8s-infra-* update as of 2021-02-24#1717

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cncf-ci:autoaudit-prow-k8s-infra-misc
Mar 1, 2021
Merged

partial-audit: k8s-infra-* update as of 2021-02-24#1717
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cncf-ci:autoaudit-prow-k8s-infra-misc

Conversation

@cncf-ci
Copy link
Copy Markdown
Contributor

@cncf-ci cncf-ci commented Feb 24, 2021

Audit Updates wg-k8s-infra

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra labels Feb 24, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2021
@cncf-ci cncf-ci changed the title audit: update as of 2021-02-24 partial-audit: k8s-infra-* update as of 2021-02-24 Feb 24, 2021
@hh
Copy link
Copy Markdown
Contributor

hh commented Feb 24, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2021
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Feb 24, 2021

/check-cla

Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Same comments as #1710 (review), and a few more in addition

"members": [
"projectEditor:k8s-infra-e2e-scale-project",
"projectOwner:k8s-infra-e2e-scale-project"
"projectEditor:k8s-infra-e2e-gpu-project",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does git see this as a move?

Comment on lines +3 to +5
"labels": {
"sig": "testing"
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self for followup: need to decide on a convention for labeling secrets

I've been labeling other secrets in kubernetes-public with e.g. labels.app=slack-infra

I had considered group=sig-testing but feel like sig=testing lines up with "only sigs can own code"

Comment on lines +5 to +6
"group:k8s-infra-prow-oncall@kubernetes.io",
"user:hh@ii.coop"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we plan on keeping this secret around, my preference would be to replace the user: with a group

longer term we should have audit use a k8s-owned account

@@ -1 +1 @@
prow-build us-central1 us-central1-c;us-central1-f;us-central1-b 67 RUNNING
prow-build us-central1 us-central1-c;us-central1-f;us-central1-b 72 RUNNING
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should have audit dump a format that is less noisy for clusters, given that this cluster auto-scales

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@hh
Copy link
Copy Markdown
Contributor

hh commented Mar 1, 2021

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit f49a3b4 into kubernetes:main Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants