partial-audit: k8s-infra-boskos-gpu-* update as of 2021-02-24#1710
partial-audit: k8s-infra-boskos-gpu-* update as of 2021-02-24#1710k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @cncf-ci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| @@ -0,0 +1 @@ | |||
| gs://kubernetes-staging-a0b6b040d4/ has no CORS configuration. | |||
There was a problem hiding this comment.
These buckets get created by kube-up
https://github.com/kubernetes/kubernetes/blob/703e2bd2ebae1cc7737c12344a9e6fb13a6019a9/cluster/gce/util.sh#L306-L316
Since they're based on project hash, they should be consistent, and we shouldn't expect too many of these per e2e project
| @@ -0,0 +1,3 @@ | |||
| Bucket Policy Only setting for gs://kubernetes-staging-2abfb0e14f: | |||
| Enabled: False | |||
There was a problem hiding this comment.
nit for followup: I would like us to consider enabling constraints/storage.uniformBucketLevelAccess so kube-up doesn't create buckets without ubla enabled
ref: https://cloud.google.com/resource-manager/docs/organization-policy/org-policy-constraints
| @@ -1,6 +1,9 @@ | |||
| NAME TITLE | |||
| compute.googleapis.com Compute Engine API | |||
| containerregistry.googleapis.com Container Registry API | |||
| { | ||
| "limit": 1000, | ||
| "metric": "XPN_SERVICE_PROJECTS" | ||
| }, |
There was a problem hiding this comment.
Don't think this is anything we did. Suspect this is a new quota type introduced for https://cloud.google.com/vpc/docs/shared-vpc
| "members": [ | ||
| "serviceAccount:service-220512457637@containerregistry.iam.gserviceaccount.com" | ||
| ], | ||
| "role": "roles/containerregistry.ServiceAgent" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cncf-ci, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/check-cla |
Audit Updates wg-k8s-infra