partial-audit: k8s-infra-* update as of 2021-02-24 #1717
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| NAME TITLE | ||
| compute.googleapis.com Compute Engine API | ||
| containerregistry.googleapis.com Container Registry API | ||
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| storage-api.googleapis.com Google Cloud Storage JSON API | ||
| storage-component.googleapis.com Cloud Storage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Bucket Policy Only setting for gs://kubernetes-staging-cfeccb2cc5: | ||
| Enabled: False | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gs://kubernetes-staging-cfeccb2cc5/ has no CORS configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gs://kubernetes-staging-cfeccb2cc5/ has no logging configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| NAME TITLE | ||
| compute.googleapis.com Compute Engine API | ||
| containerregistry.googleapis.com Container Registry API | ||
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| storage-api.googleapis.com Google Cloud Storage JSON API | ||
| storage-component.googleapis.com Cloud Storage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Bucket Policy Only setting for gs://kubernetes-staging-39e765ac61-asia: | ||
| Enabled: False | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gs://kubernetes-staging-39e765ac61-asia/ has no CORS configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "projectEditor:k8s-infra-e2e-ingress-project", | ||
| "projectOwner:k8s-infra-e2e-ingress-project" | ||
| ], | ||
| "role": "roles/storage.legacyBucketOwner" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "projectViewer:k8s-infra-e2e-ingress-project" | ||
| ], | ||
| "role": "roles/storage.legacyBucketReader" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gs://kubernetes-staging-39e765ac61-asia/ has no logging configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| NAME TITLE | ||
| compute.googleapis.com Compute Engine API | ||
| containerregistry.googleapis.com Container Registry API | ||
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| storage-api.googleapis.com Google Cloud Storage JSON API | ||
| storage-component.googleapis.com Cloud Storage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| NAME TITLE | ||
| compute.googleapis.com Compute Engine API | ||
| containerregistry.googleapis.com Container Registry API | ||
| logging.googleapis.com Cloud Logging API | ||
| monitoring.googleapis.com Cloud Monitoring API | ||
| oslogin.googleapis.com Cloud OS Login API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| storage-api.googleapis.com Google Cloud Storage JSON API | ||
| storage-component.googleapis.com Cloud Storage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "createTime": "2021-02-11T04:21:30.200768Z", | ||
| "labels": { | ||
| "sig": "testing" | ||
| }, | ||
|
Comment on lines
+3
to
+5
Contributor
There was a problem hiding this comment. note to self for followup: need to decide on a convention for labeling secrets I've been labeling other secrets in kubernetes-public with e.g. I had considered |
||
| "name": "projects/180382678033/secrets/cncf-ci-github-token", | ||
| "replication": { | ||
| "automatic": {} | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "group:k8s-infra-prow-oncall@kubernetes.io", | ||
| "user:hh@ii.coop" | ||
|
Comment on lines
+5
to
+6
Contributor
There was a problem hiding this comment. if we plan on keeping this secret around, my preference would be to replace the longer term we should have audit use a k8s-owned account |
||
| ], | ||
| "role": "roles/secretmanager.admin" | ||
| } | ||
| ], | ||
| "version": 1 | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [ | ||
| { | ||
| "createTime": "2021-02-11T20:01:09.472963Z", | ||
| "name": "projects/180382678033/secrets/cncf-ci-github-token/versions/1", | ||
| "replicationStatus": { | ||
| "automatic": {} | ||
| }, | ||
| "state": "ENABLED" | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| prow-build us-central1 us-central1-c;us-central1-f;us-central1-b 72 RUNNING | ||
|
Contributor
There was a problem hiding this comment. nit: we should have audit dump a format that is less noisy for clusters, given that this cluster auto-scales |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does git see this as a move?