-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add peer proto fields for NodeGroupTemplateNodeInfoResponse / NodeGroupAutoscalingOptions #8747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…upAutoscalingOptions
f753f84 to
2f35e9a
Compare
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/lgtm /cherry-pick cluster-autoscaler-release-1.34 |
|
@jackfrancis: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jackfrancis: new pull request created: #8748 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of PR is this?
/kind bug
/kind api-change
/kind cleanup
Follow-up to #8660 that missed a v1.Node and v1.Duration fields which have the same issue with not being reliable proto messages, and not being proto messages at all in 1.35.
What this PR does / why we need it:
Adds peer fields which will continue working with 1.35 Kubernetes libraries (nodeBytes for node and standard proto.Duration fields for durations).
cc @jackfrancis