Skip to content

Remove incorrect Kubernetes REST API types in proto messages #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2025
Merged

Remove incorrect Kubernetes REST API types in proto messages #8746

merged 3 commits into from
Nov 5, 2025

Conversation

@jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Nov 4, 2025

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

This follows #8660, which introduced replacement fields for Kubernetes REST API types that are being used as proto messages. Those types will not be valid starting w/ Kubernetes 1.35.

These types were removed: Pod/Node/StartTime/EndTime

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove incorrect Kubernetes REST API types in proto messages

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/externalgrpc Issues or PRs related to the External gRPC provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Nov 4, 2025
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 4, 2025

/assign @liggitt

@jackfrancis jackfrancis mentioned this pull request Nov 4, 2025
Merged
liggitt
liggitt reviewed Nov 4, 2025
View reviewed changes
cluster-autoscaler/cloudprovider/externalgrpc/protos/externalgrpc.pb.go Outdated
state protoimpl.MessageState `protogen:"open.v1"`
// nodeInfo is the extracted data from the cloud provider, as a primitive Kubernetes Node type.
NodeInfo *v11.Node `protobuf:"bytes,1,opt,name=nodeInfo,proto3" json:"nodeInfo,omitempty"`
NodeInfo *v1.Node `protobuf:"bytes,1,opt,name=nodeInfo,proto3" json:"nodeInfo,omitempty"`
Copy link
Member

@liggitt liggitt Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah... missed this in the earlier PR 🤦

all the REST API types have the identical issue of not being real reliable protomessages since $epoch, and being explicitly not protomessages in 1.35

Need to do the same thing here.

Copy link
Member

@liggitt liggitt Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh... I'll open a PR to master again ... so sorry...

Copy link
Contributor Author

@jackfrancis jackfrancis Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, this is distracting me from kubecon prep stress so 🙏

Copy link
Member

@liggitt liggitt Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #8747

cluster-autoscaler/expander/grpcplugin/protos/expander.pb.go
import (
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
v1 "k8s.io/api/core/v1"
Copy link
Member

@liggitt liggitt Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good and what I expected to see in the other generated file

@jackfrancis jackfrancis force-pushed the proto-rm-deprecated-fields branch from 87ef157 to a627ed2 Compare November 4, 2025 23:39
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2025
@jackfrancis jackfrancis mentioned this pull request Nov 4, 2025
Merged
@liggitt
Copy link
Member

liggitt commented Nov 5, 2025

/lgtm
/hold in case you want more eyes or test results before merge

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 5, 2025
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 5, 2025

cc @towca @x13n

I think we're good to merge

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit a257623 into kubernetes:master Nov 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbonfigli dbonfigli Awaiting requested review from dbonfigli

@feiskyer feiskyer Awaiting requested review from feiskyer

1 more reviewer

@liggitt liggitt liggitt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/externalgrpc Issues or PRs related to the External gRPC provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackfrancis @k8s-ci-robot @liggitt