Skip to content

[cluster-autoscaler-release-1.34] Add peer proto fields for NodeGroupTemplateNodeInfoResponse / NodeGroupAutoscalingOptions #8748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

[cluster-autoscaler-release-1.34] Add peer proto fields for NodeGroupTemplateNodeInfoResponse / NodeGroupAutoscalingOptions #8748

merged 1 commit into from
Nov 4, 2025
+244 −68

Conversation

@k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Nov 4, 2025

This is an automated cherry-pick of #8747

/assign jackfrancis

The cluster-autoscaler cloudprovider/externalgrpc NodeGroupTemplateNodeInfoResponse and NodeGroupAutoscalingOptions APIs deprecate the nodeInfo, scaleDownUnneededTime, scaleDownUnreadyTime, MaxNodeProvisionTime fields, in favor of nodeBytes, scaleDownUnneededDuration, scaleDownUnreadyDuration, MaxNodeProvisionDuration fields.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 4, 2025
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 4, 2025
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area area/cluster-autoscaler labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot added area/provider/externalgrpc Issues or PRs related to the External gRPC provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Nov 4, 2025
jackfrancis
jackfrancis approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit a76e813 into kubernetes:cluster-autoscaler-release-1.34 Nov 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@dbonfigli dbonfigli Awaiting requested review from dbonfigli

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

@jackfrancis jackfrancis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/externalgrpc Issues or PRs related to the External gRPC provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k8s-infra-cherrypick-robot @k8s-ci-robot @jackfrancis @liggitt