-
Notifications
You must be signed in to change notification settings - Fork 199
fixing vm patch logic using correct api version #3299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing vm patch logic using correct api version #3299
Conversation
|
Hi @nikhilbarge. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
74ea237 to
e52bc64
Compare
chethanv28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, nikhilbarge, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* set securityContext for all containers in cns-csi controller pod (#3282) * test step fix (#3290) * CSI sidecar bump up (#3281) * vanilla test fix for k8s upgrade 1.33 (#3292) * Supervisor - Upgrade external provisioner (#3285) Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.31 Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.30 Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.29 * poll timeout fix and log message fix for storagepolicyusage (#3260) * ginkgo-label on tests (#3298) * fixing vm patch logic using correct api version (#3299) --------- Co-authored-by: Divyen Patel <[email protected]> Co-authored-by: Raj Kumar Gupta <[email protected]> Co-authored-by: Chethan Venkatesh <[email protected]> Co-authored-by: Satyanarayana Kolluri <[email protected]> Co-authored-by: sipriyaa <[email protected]>
What this PR does / why we need it:
To Fix vm patch logic using correct api version
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Manual testing performed to verify patch operation while created virtualmachine with api version v1alpha3.
v1alpha3_patch_testing.log
Special notes for your reviewer:
Release note: