Skip to content

Conversation

@nikhilbarge
Copy link
Contributor

@nikhilbarge nikhilbarge commented May 27, 2025

What this PR does / why we need it:
To Fix vm patch logic using correct api version

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Manual testing performed to verify patch operation while created virtualmachine with api version v1alpha3.

{"level":"info","time":"2025-05-27T06:51:07.001520842Z","caller":"utils/utils.go:331","msg":"successfully fetched the virtual machines with name wl-calico-node-pool-1-jwml4-xntjd-w2p75 and namespace test-ns","TraceId":"ee57dca4-d293-4fe3-b733-710b6282d9de"}
{"level":"info","time":"2025-05-27T06:51:07.001810991Z","caller":"utils/utils.go:437","msg":"PatchVirtualMachine: patch virtualmachine name: wl-calico-node-pool-1-jwml4-xntjd-w2p75","TraceId":"ee57dca4-d293-4fe3-b733-710b6282d9de"}
{"level":"info","time":"2025-05-27T06:51:07.004121206Z","caller":"utils/utils.go:441","msg":"PatchVirtualMachine: converting v1alpha4 VirtualMachine to v1alpha3 VirtualMachine, name: wl-calico-node-pool-1-jwml4-xntjd-w2p75","TraceId":"ee57dca4-d293-4fe3-b733-710b6282d9de"}
{"level":"info","time":"2025-05-27T06:51:07.199402762Z","caller":"utils/utils.go:504","msg":"PatchVirtualMachine: successfully patched the virtualmachine, name: wl-calico-node-pool-1-jwml4-xntjd-w2p75","TraceId":"ee57dca4-d293-4fe3-b733-710b6282d9de"}

v1alpha3_patch_testing.log

Special notes for your reviewer:

Release note:

Fix vm patch logic using correct api version 

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2025
@nikhilbarge nikhilbarge force-pushed the fix_vm_patch_logic branch from 74ea237 to e52bc64 Compare May 27, 2025 13:23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2025
Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, nikhilbarge, vdkotkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 86b3032 into kubernetes-sigs:master May 27, 2025
12 checks passed
nikhilbarge added a commit to nikhilbarge/vsphere-csi-driver that referenced this pull request May 27, 2025
k8s-ci-robot pushed a commit that referenced this pull request May 27, 2025
* set securityContext for all containers in cns-csi controller pod (#3282)

* test step fix (#3290)

* CSI sidecar bump up (#3281)

* vanilla test fix for k8s upgrade 1.33 (#3292)

* Supervisor - Upgrade external provisioner (#3285)

Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.31
Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.30
Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.29

* poll timeout fix and log message fix for storagepolicyusage (#3260)

* ginkgo-label on tests (#3298)

* fixing vm patch logic using correct api version (#3299)

---------

Co-authored-by: Divyen Patel <[email protected]>
Co-authored-by: Raj Kumar Gupta <[email protected]>
Co-authored-by: Chethan Venkatesh <[email protected]>
Co-authored-by: Satyanarayana Kolluri <[email protected]>
Co-authored-by: sipriyaa <[email protected]>
anuj087 pushed a commit to anuj087/vsphere-csi-driver that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants