Skip to content

vanilla test fix for k8s upgrade 1.33 #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
May 23, 2025
Merged

vanilla test fix for k8s upgrade 1.33 #3292

k8s-ci-robot merged 1 commit into from
May 23, 2025

Conversation

@rajguptavm
Copy link
Contributor

@rajguptavm rajguptavm commented May 22, 2025 •
edited
Loading

What this PR does / why we need it:
Vanilla test fix for k8s upgrade 1.33
Polling added for namespace deletion tests
Ginkgo Label fix for vanilla in storagepolicy tests

Testing done:
YES
https://gist.github.com/rajguptavm/e265772ba19976944516edddbb2f4b3b

@rpanduranga @sipriyaa Please review it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2025

Hi @rajguptavm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2025
@rajguptavm rajguptavm changed the title [WIP] vanilla test fix for k8s upgrade 1.33 vanilla test fix for k8s upgrade 1.33 May 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2025
@kavyashree-r
Copy link
Contributor

kavyashree-r commented May 23, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2025
@kavyashree-r
Copy link
Contributor

kavyashree-r commented May 23, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kavyashree-r
Copy link
Contributor

kavyashree-r commented May 23, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 23, 2025
@kavyashree-r
Copy link
Contributor

kavyashree-r commented May 23, 2025

/lgtm

@rajguptavm
Copy link
Contributor Author

rajguptavm commented May 23, 2025

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 23, 2025

@rajguptavm: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 06068a9 into kubernetes-sigs:master May 23, 2025
11 checks passed
@rajguptavm rajguptavm deleted the vanilla-test-fix branch May 23, 2025 09:12
nikhilbarge pushed a commit to nikhilbarge/vsphere-csi-driver that referenced this pull request May 27, 2025
@rajguptavm @nikhilbarge
vanilla test fix for k8s upgrade 1.33 (kubernetes-sigs#3292)
4eb64b4
k8s-ci-robot pushed a commit that referenced this pull request May 27, 2025
@nikhilbarge @divyenpatel
@rajguptavm @chethanv28 @kolluria @sipriyaa
Cherry pick commits upto 86b3032 (#3306)
7e3166c 
* set securityContext for all containers in cns-csi controller pod (#3282)

* test step fix (#3290)

* CSI sidecar bump up (#3281)

* vanilla test fix for k8s upgrade 1.33 (#3292)

* Supervisor - Upgrade external provisioner (#3285)

Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.31
Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.30
Updated `csi-provisioner` version to `v5.0.2_vmware.6` for K83 1.29

* poll timeout fix and log message fix for storagepolicyusage (#3260)

* ginkgo-label on tests (#3298)

* fixing vm patch logic using correct api version (#3299)

---------

Co-authored-by: Divyen Patel <[email protected]>
Co-authored-by: Raj Kumar Gupta <[email protected]>
Co-authored-by: Chethan Venkatesh <[email protected]>
Co-authored-by: Satyanarayana Kolluri <[email protected]>
Co-authored-by: sipriyaa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

1 more reviewer

@sipriyaa sipriyaa sipriyaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kavyashree-r kavyashree-r

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajguptavm @k8s-ci-robot @kavyashree-r @sipriyaa