Skip to content

fullsync fix: Fix Syncer panics due to incorrect PVC configuration #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fullsync fix: Fix Syncer panics due to incorrect PVC configuration #3269

merged 1 commit into from
May 13, 2025

Conversation

@nikhilbarge
Copy link
Contributor

@nikhilbarge nikhilbarge commented Apr 30, 2025 •
edited
Loading

What this PR does / why we need it:
Fix Syncer panics with NPE due to nil claimreference for PVC
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Manual Testing Performed
full-sync-nil-claimref-manual-testing.log
fullsync-nil-claimref-vsphere-syncer.log

Special notes for your reviewer:

Release note:

Fix Syncer panics due to incorrect PVC configuration

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 30, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 30, 2025

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2025
@akankshapanse
Copy link
Contributor

akankshapanse commented May 2, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2025
@akankshapanse
Copy link
Contributor

akankshapanse commented May 2, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2025
@nikhilbarge nikhilbarge changed the title fullsync fix: add nil check on claimreference while listing pvs fullsync fix: Fix Syncer panics due to incorrect PVC configuration May 13, 2025
@divyenpatel
Copy link
Member

divyenpatel commented May 13, 2025

@nikhilbarge can you explain on the bug when this condition happens?

@nikhilbarge
Copy link
Contributor Author

nikhilbarge commented May 13, 2025

@nikhilbarge can you explain on the bug when this condition happens?

observed we hit this issue when there is no volumeclaim associated with pv (claimref is nil). this happen when user statically provision volume but create only PV and no associated PVC.

@divyenpatel
Copy link
Member

divyenpatel commented May 13, 2025

/ok-to-test

divyenpatel
divyenpatel approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akankshapanse, divyenpatel, nikhilbarge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [akankshapanse,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3326adc into kubernetes-sigs:master May 13, 2025
12 checks passed
nikhilbarge added a commit to nikhilbarge/vsphere-csi-driver that referenced this pull request May 14, 2025
@nikhilbarge
fullsync fix: add nil check on claimreference while listing pvs (kube…
3f70da6 
…rnetes-sigs#3269)
k8s-ci-robot pushed a commit that referenced this pull request May 16, 2025
@nikhilbarge @kolluria @jsafrane
Cherry pick commits upto 639469d (#3277)
3081a6c 
* Reverted the refactoring done as part of #3234 (#3266)

* Fix panic on DeletedFinalStateUnknown (#3262)

Properly handle DeletedFinalStateUnknown when watching Nodes

* fullsync fix: add nil check on claimreference while listing pvs (#3269)

* bump up k8s version to 1.33.0 (#3274)

---------

Co-authored-by: Satyanarayana Kolluri <[email protected]>
Co-authored-by: Jan Šafránek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyenpatel divyenpatel divyenpatel approved these changes

@adikul30 adikul30 Awaiting requested review from adikul30

@akankshapanse akankshapanse Awaiting requested review from akankshapanse

Assignees

@divyenpatel divyenpatel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikhilbarge @k8s-ci-robot @akankshapanse @divyenpatel