Fix the regression introduced in #3234 #3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
Hi @kolluria. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
kolluria
force-pushed
the
fix-refactor-bug
branch
2 times, most recently
from
9d97c40 to
9b8e448
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
vdkotkar
reviewed
Apr 30, 2025
k8s-ci-robot
added
size/M
Contributor
|
/ok-to-test |
Contributor
|
/approve |
Contributor
|
@vdkotkar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Contributor
Author
|
After reverting the changes from #3234 and taking the latest pull from the master, I created an image Controller logs before my change - Controller logs after my change - Also, verified that the pods have been stable - |
Contributor
Author
|
/ok-to-test |
Contributor
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akankshapanse, kolluria, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
nikhilbarge
pushed a commit
to nikhilbarge/vsphere-csi-driver
that referenced
this pull request
May 14, 2025
k8s-ci-robot
pushed a commit
that referenced
this pull request
May 16, 2025
* Reverted the refactoring done as part of #3234 (#3266) * Fix panic on DeletedFinalStateUnknown (#3262) Properly handle DeletedFinalStateUnknown when watching Nodes * fullsync fix: add nil check on claimreference while listing pvs (#3269) * bump up k8s version to 1.33.0 (#3274) --------- Co-authored-by: Satyanarayana Kolluri <[email protected]> Co-authored-by: Jan Šafránek <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As part of #3234, I refactored the BeforeServe method which introduced a regression in Vanilla deployments which is causing the CSI controller to stay stuck in CLBO -
The
vsphere-csi-controllercontainers contain the following error -The regression is due to the way
cfg.Global.ClusterIDis updated (here and here) and subsequently checked here.This MR reverts the refactoring changes introduced.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes regression introduced in #3234Testing done:
Verified that the CSI controller pods have been stable after applying the fix.
Special notes for your reviewer:
Release note: