Fix panic on DeletedFinalStateUnknown #3262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly handle DeletedFinalStateUnknown when watching Nodes
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
Edit: I tested it manually. Added / deleted ~10 API server nodes, no panic so far. |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/assign @shalini-b @divyenpatel @xing-yang |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
nikhilbarge
pushed a commit
to nikhilbarge/vsphere-csi-driver
that referenced
this pull request
May 14, 2025
Properly handle DeletedFinalStateUnknown when watching Nodes
k8s-ci-robot
pushed a commit
that referenced
this pull request
May 16, 2025
* Reverted the refactoring done as part of #3234 (#3266) * Fix panic on DeletedFinalStateUnknown (#3262) Properly handle DeletedFinalStateUnknown when watching Nodes * fullsync fix: add nil check on claimreference while listing pvs (#3269) * bump up k8s version to 1.33.0 (#3274) --------- Co-authored-by: Satyanarayana Kolluri <[email protected]> Co-authored-by: Jan Šafránek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Properly handle
DeletedFinalStateUnknownwhen watching NodesWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3261Testing done:
Manually, the CSI driver no longer panics when an API server node is removed.
Special notes for your reviewer:
Release note: