chore: Bump sigs.k8s.io/controller-runtime and fix issues#424
Open
tomasaschan wants to merge 5 commits intomasterfrom
Open
chore: Bump sigs.k8s.io/controller-runtime and fix issues#424tomasaschan wants to merge 5 commits intomasterfrom
tomasaschan wants to merge 5 commits intomasterfrom
Conversation
This bumps these dependencies to the latest versions, keeping them in sync with each other. The update in validator.go is to adjust to a renamed function in k8s.io/apimachinery.
New controller-runtime versions take advantage of WatchList which removes the initial List request.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomasaschan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This was referenced Feb 12, 2026
Member
Author
|
Any chance you of getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This updates the library to support recent versions of
sigs.k8s.io/controller-runtimeandk8s.io/*. We need this in order to perform version bumps of those libraries in our operator projects that also reference KDP.In modern
sigs.k8s.io/controller-runtime, the client takes advantage of the newWatchListrequest, so themockkubeapiserverhas been extened with support for this (thanks, Cursor!) and the golden test expectations updated to match the new behavior.We also tag a new release to be able to use these improvements without pinning a commit. The version number is chosen to match the versioning strategy but as discussed in #407 we don't release any intermediate versions here; we can go back and do that retroactively if anyone asks for it.
This is a re-do of #422 due to weird branch protection.
Which issue(s) this PR fixes:
Fixes #407
Closes #422
Closes #423
Special notes for your reviewer:
Don't be scared by the +/- stats; ignoring changes to go.mod/go.sum/go.work/go.work.sum and http expectation logs, which are all very much generated, the diff is more like +50/-10.
Additional documentation: