Skip to content

Work around branch protection#423

Closed
tomasaschan wants to merge 1 commit intobump-and-fixfrom
bump-and-fix-2
Closed

Work around branch protection#423
tomasaschan wants to merge 1 commit intobump-and-fixfrom
bump-and-fix-2

Conversation

@tomasaschan
Copy link
Copy Markdown
Member

@tomasaschan tomasaschan commented Feb 12, 2026

This is just to work around the fact that git won't let me push to my feature branch :/

@tomasaschan
Re-generate http expectations
3eb4053 
New controller-runtime versions take advantage of WatchList which removes the initial List request.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2026
@tomasaschan
Copy link
Copy Markdown
Member Author

tomasaschan commented Feb 12, 2026

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2026

@tomasaschan: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 12, 2026

@tomasaschan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-declarative-test 3eb4053 link true /test pull-declarative-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tomasaschan tomasaschan mentioned this pull request Feb 12, 2026
Open
@tomasaschan
Copy link
Copy Markdown
Member Author

tomasaschan commented Feb 12, 2026

Superceded by #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atoato88 atoato88 Awaiting requested review from atoato88

@justinsb justinsb Awaiting requested review from justinsb

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasaschan @k8s-ci-robot