Skip to content

Bump sigs.k8s.io/controller-runtime and k8s.io/*#422

Closed
tomasaschan wants to merge 4 commits intomasterfrom
bump-and-fix
Closed

Bump sigs.k8s.io/controller-runtime and k8s.io/*#422
tomasaschan wants to merge 4 commits intomasterfrom
bump-and-fix

Conversation

@tomasaschan
Copy link
Copy Markdown
Member

@tomasaschan tomasaschan commented Feb 12, 2026

What this PR does / why we need it:

This ensures the library is compatible with the latest versions of sigs.k8s.io/controller-runtime and the matching versions of k8s.io/*. We need this internally to be able to make the matching version bumps in our controller implementations.

Which issue(s) this PR fixes:

It also tags a new version, which closes #407.

Special notes for your reviewer:

Unfortunately there is no version of k8s.io/apimachinery that supports both diff.StringDiff and diff.Diff so we have to simply bite the bullet and change the code, and also push forward.

As discussed in #407, I don't see the need to release a version of KDP for each version of sigs.k8s.io/controller-runtime we've missed; we can do that retroactively if anyone asks for it.

This bumps these dependencies to the latest versions,
keeping them in sync with each other. The update in
validator.go is to adjust to a renamed function in
k8s.io/apimachinery.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@tomasaschan tomasaschan removed the request for review from atoato88 February 12, 2026 12:47
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 12, 2026
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@tomasaschan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-declarative-test c423963 link true /test pull-declarative-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tomasaschan
Copy link
Copy Markdown
Member Author

Superseded by #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time to cut a new release?

2 participants