Bump sigs.k8s.io/controller-runtime and k8s.io/*#422
Bump sigs.k8s.io/controller-runtime and k8s.io/*#422tomasaschan wants to merge 4 commits intomasterfrom
Conversation
This bumps these dependencies to the latest versions, keeping them in sync with each other. The update in validator.go is to adjust to a renamed function in k8s.io/apimachinery.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomasaschan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tomasaschan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Superseded by #424 |
What this PR does / why we need it:
This ensures the library is compatible with the latest versions of
sigs.k8s.io/controller-runtimeand the matching versions ofk8s.io/*. We need this internally to be able to make the matching version bumps in our controller implementations.Which issue(s) this PR fixes:
It also tags a new version, which closes #407.
Special notes for your reviewer:
Unfortunately there is no version of
k8s.io/apimachinerythat supports bothdiff.StringDiffanddiff.Diffso we have to simply bite the bullet and change the code, and also push forward.As discussed in #407, I don't see the need to release a version of KDP for each version of sigs.k8s.io/controller-runtime we've missed; we can do that retroactively if anyone asks for it.