-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plugin: exec-all #18
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
plugins/exec-all.yaml
Outdated
matchExpressions: | ||
- {key: os, operator: In, values: [linux]} | ||
version: "v1.0.0" | ||
shortDescription: "Execute a command in all of the container in a specified resource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks!
This looks fantastic! Found a small typo. |
plugins/exec-all.yaml
Outdated
to: "." | ||
selector: | ||
matchExpressions: | ||
- {key: os, operator: In, values: [linux]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this not work on macOS as well? If so, please add darwin
to this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added darwin
Locally verified. Thanks. |
@jpdasma Do you mind signing the CNCF CLA at the issue kubernetes/org#599 so we can complete the transfer of the index repository to Kubernetes as a sub-project? |
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [kubernetes-sigs#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [kubernetes-sigs#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15)
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [kubernetes-sigs#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [kubernetes-sigs#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15) Signed-off-by: Cornelius Weig <[email protected]>
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [kubernetes-sigs#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [kubernetes-sigs#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15) Signed-off-by: Cornelius Weig <[email protected]>
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15) Signed-off-by: Cornelius Weig <[email protected]>
@jpdasma Friendly reminder to see if you can sign the CNCF CLA. |
More details with regards to the plugin here: https://github.com/jpdasma/kubectl-exec-all
Sample usage:
kubectl plugin exec-all daemonset docker -- docker system prune -a -f
Checklist for plugin developers:
kubectl plugin install --source
)