Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin: exec-all #18

Merged
merged 1 commit into from
Sep 5, 2018
Merged

add plugin: exec-all #18

merged 1 commit into from
Sep 5, 2018

Conversation

jpdasma
Copy link
Contributor

@jpdasma jpdasma commented Sep 1, 2018

More details with regards to the plugin here: https://github.com/jpdasma/kubectl-exec-all

Sample usage:

kubectl plugin exec-all daemonset docker -- docker system prune -a -f


Checklist for plugin developers:

  • [/] Read the Plugin Naming Guide
  • [/] Verify the installation from URL works (kubectl plugin install --source)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jpdasma
Copy link
Contributor Author

jpdasma commented Sep 2, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@jpdasma jpdasma changed the title Added exec-all plugin Added new plugin: exec-all Sep 2, 2018
matchExpressions:
- {key: os, operator: In, values: [linux]}
version: "v1.0.0"
shortDescription: "Execute a command in all of the container in a specified resource"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: containers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@ahmetb
Copy link
Member

ahmetb commented Sep 4, 2018

This looks fantastic! Found a small typo.

to: "."
selector:
matchExpressions:
- {key: os, operator: In, values: [linux]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this not work on macOS as well? If so, please add darwin to this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added darwin

@ahmetb ahmetb changed the title Added new plugin: exec-all add plugin: exec-all Sep 4, 2018
@ahmetb
Copy link
Member

ahmetb commented Sep 5, 2018

Locally verified. Thanks.

@ahmetb ahmetb merged commit a574f50 into kubernetes-sigs:master Sep 5, 2018
@ahmetb
Copy link
Member

ahmetb commented Mar 18, 2019

@jpdasma Do you mind signing the CNCF CLA at the issue kubernetes/org#599 so we can complete the transfer of the index repository to Kubernetes as a sub-project?

corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)
corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <[email protected]>
ahmetb pushed a commit that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <[email protected]>
@ahmetb
Copy link
Member

ahmetb commented Mar 26, 2019

@jpdasma Friendly reminder to see if you can sign the CNCF CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants