Flag --namespace now implies --only-scope=namespace
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2019 14:25
Before, the effect of `--namespace` was to exclude namespace resources from namespaces other than the given one, because all cluster-scoped resources were still printed. Now, `--namespace` will only show namespaced resources from the given namespace.
corneliusweig
force-pushed
the
namespace-restricts-scope
branch
from
65b8339 to
0944390
Compare
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 33.56% 33.56%
=======================================
Files 6 6
Lines 286 286
=======================================
Hits 96 96
Misses 184 184
Partials 6 6
Continue to review full report at Codecov.
|
corneliusweig
added a commit
to corneliusweig/krew-index
that referenced
this pull request
Mar 25, 2019
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [kubernetes-sigs#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [kubernetes-sigs#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15)
corneliusweig
added a commit
to corneliusweig/krew-index
that referenced
this pull request
Mar 25, 2019
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [kubernetes-sigs#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [kubernetes-sigs#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15) Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
added a commit
to corneliusweig/krew-index
that referenced
this pull request
Mar 25, 2019
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [kubernetes-sigs#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [kubernetes-sigs#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15) Signed-off-by: Cornelius Weig <[email protected]>
2 tasks
ahmetb
pushed a commit
to kubernetes-sigs/krew-index
that referenced
this pull request
Mar 25, 2019
Release notes: * Flag `--namespace` now implies `--only-scope=namespace` [#18](corneliusweig/ketall#18) * Add new flag `--since` to filter resources by creation timestamp [#17](corneliusweig/ketall#17) * Fix travis releases [#15](corneliusweig/ketall#15) Signed-off-by: Cornelius Weig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the effect of
--namespacewas to exclude namespace resources from namespaces other than the given one, because all cluster-scoped resources were still printed. Now,--namespacewill only show namespaced resources from the given namespace.