Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #17

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Add PR template #17

merged 1 commit into from
Aug 20, 2018

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Aug 13, 2018

It takes effect below in this PR :)

/cc @lbb


Checklist for plugin developers:

  • Read the Plugin Naming Guide
  • Verify the installation from URL works (kubectl plugin install --source)

Signed-off-by: Ahmet Alp Balkan <[email protected]>
Copy link
Contributor

@lbb lbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/ I like it.

@lbb
Copy link
Contributor

lbb commented Aug 20, 2018

/cc @ahmetb

@ahmetb ahmetb merged commit e7b4daa into kubernetes-sigs:master Aug 20, 2018
corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)
corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig added a commit to corneliusweig/krew-index that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[kubernetes-sigs#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[kubernetes-sigs#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <[email protected]>
ahmetb pushed a commit that referenced this pull request Mar 25, 2019
Release notes:

* Flag `--namespace` now implies `--only-scope=namespace`
[#18](corneliusweig/ketall#18)
* Add new flag `--since` to filter resources by creation timestamp
[#17](corneliusweig/ketall#17)
* Fix travis releases
[#15](corneliusweig/ketall#15)

Signed-off-by: Cornelius Weig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants