Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update Fedora to 38 #3410

Closed
wants to merge 1 commit into from
+13 −6
Closed

CI: update Fedora to 38 #3410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/cgroup2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
docker:
name: Cgroup v2
# nested virtualization is only available on macOS hosts
runs-on: macos-12
runs-on: macos-13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 seems less stable than 12 from my experience in Lima

timeout-minutes: 30
strategy:
fail-fast: false
Expand All @@ -31,6 +31,17 @@ jobs:
- name: Check out code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

#fix https://github.com/kubernetes-sigs/kind/issues/3411
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed? #3411 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Action workflows have been reworked, so this may not even be relevant anymore.

# brew uninstall virtualbox
# vbcask_url="https://raw.githubusercontent.com/Homebrew/homebrew-cask/aa3c55951fc9d687acce43e5c0338f42c1ddff7b/Casks/virtualbox.rb"
# curl -LO $vbcask_url
# brew install ./virtualbox.rb
# rm ./virtualbox.rb
- name: Set up Virtualbox
run: |
brew install --cask vagrant
brew install --cask virtualbox

- name: Boot Fedora
run: |
ln -sf ./hack/ci/Vagrantfile ./Vagrantfile
Expand Down
6 changes: 1 addition & 5 deletions hack/ci/Vagrantfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@

# Vagrant box for testing kind with cgroup v2
Vagrant.configure("2") do |config|
# `config.vm.box = "fedora/37-cloud-base"` seems flaky,
# so we specify the URL explicitly.
# Mirrors can be found at here: https://admin.fedoraproject.org/mirrormanager/mirrors/Fedora/37/x86_64
config.vm.box = "dummy"
config.vm.box_url = "https://iad.mirror.rackspace.com/fedora/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-Vagrant-37-1.7.x86_64.vagrant-virtualbox.box"
config.vm.box = "fedora/38-cloud-base"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now 39

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @yankay

# macOS github actions runners have 3 cores and 14 GB of ram
# assume some ram is needed for the host environment but very little CPU
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
Expand Down