Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update Fedora to 38 #3410

Closed
wants to merge 1 commit into from
Closed

CI: update Fedora to 38 #3410

wants to merge 1 commit into from

Conversation

yankay
Copy link
Member

@yankay yankay commented Nov 1, 2023 •
edited
Loading

According the https://endoflife.date/fedora , the fedora 37 will EOL at (15 Dec 2023), so update it.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yankay
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2023
neolit123
neolit123 reviewed Nov 1, 2023
View reviewed changes
hack/ci/Vagrantfile Outdated
@@ -3,11 +3,11 @@

# Vagrant box for testing kind with cgroup v2
Vagrant.configure("2") do |config|
# `config.vm.box = "fedora/37-cloud-base"` seems flaky,
# `config.vm.box = "fedora/38-cloud-base"` seems flaky,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still flaky, or can this comment be removed?

@yankay yankay force-pushed the update-ci-fedora-38 branch 3 times, most recently from eed2c93 to 0c044ef Compare November 1, 2023 13:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2023
@yankay yankay force-pushed the update-ci-fedora-38 branch 6 times, most recently from 9d71e77 to 574aadd Compare November 1, 2023 14:02
@yankay
update ci fedora 38
574aadd 
Signed-off-by: Kay Yan <[email protected]>
AkihiroSuda
AkihiroSuda reviewed Nov 14, 2023
View reviewed changes
hack/ci/Vagrantfile
# Mirrors can be found at here: https://admin.fedoraproject.org/mirrormanager/mirrors/Fedora/37/x86_64
config.vm.box = "dummy"
config.vm.box_url = "https://iad.mirror.rackspace.com/fedora/releases/37/Cloud/x86_64/images/Fedora-Cloud-Base-Vagrant-37-1.7.x86_64.vagrant-virtualbox.box"
config.vm.box = "fedora/38-cloud-base"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now 39

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @yankay

AkihiroSuda
AkihiroSuda reviewed Nov 14, 2023
View reviewed changes
.github/workflows/cgroup2.yaml
@@ -15,7 +15,7 @@ jobs:
docker:
name: Cgroup v2
# nested virtualization is only available on macOS hosts
runs-on: macos-12
runs-on: macos-13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 seems less stable than 12 from my experience in Lima

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2024
stmcginnis
stmcginnis reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a good time to refresh this?

.github/workflows/cgroup2.yaml
@@ -31,6 +31,17 @@ jobs:
- name: Check out code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

#fix https://github.com/kubernetes-sigs/kind/issues/3411
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed? #3411 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Action workflows have been reworked, so this may not even be relevant anymore.

@BenTheElder
Copy link
Member

jumping forward to 39 here #3654 and getting everything passing, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@stmcginnis stmcginnis stmcginnis left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@aojea aojea Awaiting requested review from aojea

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yankay @k8s-ci-robot @BenTheElder @neolit123 @stmcginnis @AkihiroSuda