chore(aws): document and test behavior for ALB and NLB#6063
Merged
k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom Jan 8, 2026
Merged
chore(aws): document and test behavior for ALB and NLB#6063k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom
k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Pull Request Test Coverage Report for Build 20618885687Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
docs
size/L
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
mloiseleur
changed the title
mloiseleur
changed the title
vflaux
reviewed
Dec 31, 2025
Co-authored-by: vflaux <38909103+vflaux@users.noreply.github.com>
Contributor
|
LGTM |
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Jan 8, 2026
* master: fix(api): rollback changes for omitempty (kubernetes-sigs#6086) chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080) fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082) chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063) chore(doc): Adding EKS Pod Identity Associations section for AWS (kubernetes-sigs#6084) chore(source)!: remove cloudfoundry support (kubernetes-sigs#6074) docs(source): autogenerate docs for sources with go-doc like style (kubernetes-sigs#6075) docs(rfc2136): document AXFR requirement for sync policy (kubernetes-sigs#6083)
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Jan 16, 2026
* master: (25 commits) feat(event): standardize event messages and add resource kind lookup for events (kubernetes-sigs#6101) refactor(informers): unify cache sync functions using generics (kubernetes-sigs#6102) fix(fqdn): support kind and api version (kubernetes-sigs#6097) test(fqdn): cover sources without any fqdn tests (kubernetes-sigs#6094) chore(tools): CRD generation script moved and add validation workflow (kubernetes-sigs#6079) fix(metrics): add CNAME to known record types (kubernetes-sigs#6115) chore(cloudflare): migrate customhostname to v5 (kubernetes-sigs#5891) test(provider/exoscale): improved the test coverage for exoscale provider from 62.8% to 80.4% (kubernetes-sigs#6112) feat(source): gateway api hostname source annotation (kubernetes-sigs#5959) test: cover pkg/events/fake package (kubernetes-sigs#6096) refactor(controller): controller no longer responsible for SingletonClientGenerator creation (kubernetes-sigs#6077) refactor(source): standardize FQDN template accross sources (kubernetes-sigs#6093) feat(coredns): rename ownerId and ownedBy to owner (kubernetes-sigs#6032) docs: fix typo in README (The are → There are) (kubernetes-sigs#6095) refactor(aws): abstract provider-specific boolean parsing (kubernetes-sigs#6078) refactor(api): deduplicate addKnownTypes (kubernetes-sigs#6087) fix(api): rollback changes for omitempty (kubernetes-sigs#6086) chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080) fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082) chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
I've added only tests, to explicitly capture behaviour and make it obvious. At the memont, to my understanding AWS ALB controller for NLB creates two hostnames, one prefixed with
internal-.I've explained solution here #5661 (comment).
If we think there are other options, like flag, annotation or some sort of regex or filter I could implement in this or follow-up PR.
It's great to have a better support for AWS ALB, like automated management of records, same time the ALB controller behaviour is quite unpredictable and not well documented. Happy to follow advice
Motivation
Fixes #5661
More