Skip to content

docs(rfc2136): hard learned lesson about AXFR#6083

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
avanier:avanier/arrrgh-axfr
Jan 6, 2026
Merged

docs(rfc2136): hard learned lesson about AXFR#6083
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
avanier:avanier/arrrgh-axfr

Conversation

@avanier
Copy link
Copy Markdown
Contributor

@avanier avanier commented Jan 6, 2026

What does it do ?

A minor documentation change to make the expected policy behaviour a bit more obvious when using rfc2136.

Motivation

After much raging unplanned enlightenment I figured out that the axfr flag is required for the sync policy to behave as expected. Just jotting it down for the next guy / gal / cyborg.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests (N/A)
  • Yes, I updated end user documentation accordingly

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jan 6, 2026 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: avanier / name: Alexis Vanier (28f3fc3)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 6, 2026

Welcome @avanier!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 6, 2026

Hi @avanier. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2026
@mloiseleur mloiseleur changed the title Document hard learned lesson about AXFR in rfc2136 docs(rfc2136): hard learned lesson about AXFR Jan 6, 2026
@mloiseleur
Copy link
Copy Markdown
Collaborator

mloiseleur commented Jan 6, 2026

Thanks for taking the time for this PR, @avanier 👍 .

You are welcome to open a PR for adding a warning, too.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 6, 2026

Pull Request Test Coverage Report for Build 20751591160

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 78.794%
Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 84.29%
Totals Coverage Status
Change from base Build 20661074501: -0.005%
Covered Lines: 15799
Relevant Lines: 20051
💛 - Coveralls

@ivankatliarchuk
Copy link
Copy Markdown
Member

ivankatliarchuk commented Jan 6, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4e2cf56 into kubernetes-sigs:master Jan 6, 2026
23 checks passed
@avanier avanier deleted the avanier/arrrgh-axfr branch January 6, 2026 18:19
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Jan 8, 2026
@ivankatliarchuk
Merge branch 'master' into chore-tools
c909bda 
* master:
  fix(api): rollback changes for omitempty (kubernetes-sigs#6086)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080)
  fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082)
  chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063)
  chore(doc): Adding EKS Pod Identity Associations section for AWS (kubernetes-sigs#6084)
  chore(source)!: remove cloudfoundry support (kubernetes-sigs#6074)
  docs(source): autogenerate docs for sources with go-doc like style (kubernetes-sigs#6075)
  docs(rfc2136): document AXFR requirement for sync policy (kubernetes-sigs#6083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@vflaux vflaux Awaiting requested review from vflaux

Assignees

@mloiseleur mloiseleur

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avanier @k8s-ci-robot @mloiseleur @coveralls @ivankatliarchuk