Headless service: retrieve endpoints via Endpoints resource; evaluate spec.publishNotReadyAddresses by alfredkrohmer · Pull Request #1005 · kubernetes-sigs/external-dns

alfredkrohmer · 2019-04-28T08:45:24Z

Currently, the endpoints of headless services are retrieved
by querying pods using the pod selector of the service.
Instead, we now query for an Endpoints resource with the
same name as the Service object to get the endpoints for the
service. This is needed in order to support the
spec.publishNotReadyPods attribute of a service.

needs documentation and manifest/helm chart update to include permissions to retrieve endpoints resources

alfredkrohmer · 2019-04-28T08:46:06Z

/assign @Raffo

alfredkrohmer · 2019-04-28T12:05:04Z

Note: this will change the default behaviour. Before, the IPs of all Running pods of a headless services were published; now this is only the case when the .spec.publishNotReadyAddresses is set to true.

alfredkrohmer · 2019-06-08T21:05:36Z

@Raffo @njuettner any chance to get this reviewed?

Raffo

@devkid I added one minor comment and I have two requests:

Add a comment to the function extractHeadlessEndpoints to specify what it does. I know there was no comment before but this was IMO bad and we now have a chance to fix it, especially with the changed behaviour.
Write a little sentence that we can add to future release notes on how the behaviour has changed.

Additionally, I'm thinking wether we should add a flag to enable/disable the changed behaviour. I think we could add it and keep it around for a few releases before getting rid of it. WDYT? /cc @linki @njuettner

source/service.go

alfredkrohmer · 2019-08-23T11:15:14Z

@Raffo added an option to restore the old behavior via CLI flag and added a comment for extractHeadlessEndpoints.

alfredkrohmer · 2019-09-17T08:57:22Z

Failing test is fixed now.

Description for release:

Breaking change: Endpoints (pod IPs) for the service source are now retrieved using the Endpoints kubernetes resource instead of using the selector of the service to query for pods and their IPs. The implication is that unready pods will not be picked up anymore by external-dns by default. In order to restore the old behavior and also register IPs of unready pods with DNS:

for a single service, set .spec.publishNotReadyAddresses to true

to restore the old behavior globally, start external-dns with --always-publish-not-ready-addresses

judofyr · 2019-10-30T11:58:30Z

Any update on this?

alfredkrohmer · 2019-11-24T08:18:39Z

Conflict resolved, documentation with inline RBAC permissions updated. I will create a pull request in https://github.com/helm/charts to up the version and add the endpoints resources permissions when there is a new release.

vivekgarg20 · 2019-12-09T12:40:26Z

When is this targeted?

ashley · 2020-01-17T16:23:54Z

Any update on this?

njuettner

added some comments, PTAL.

source/service.go

source/service_test.go

docs/tutorials/alibabacloud.md

… spec.publishNotReadyAddresses Currently, the endpoints of headless services are retrieved by querying pods using the pod selector of the service. Instead, we now query for an Endpoints resource with the same name as the Service object to get the endpoints for the service. This is needed in order to support the spec.publishNotReadyPods attribute of a service.

…ices

njuettner

/lgtm
/cc @Raffo @linki

njuettner · 2020-03-04T13:35:43Z

/approve

k8s-ci-robot · 2020-03-04T13:35:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devkid, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it

as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it Signed-off-by: Julián Martínez <julian.martinez@piksel.com>

as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it Version bumped to 2.20.4 Signed-off-by: Julián Martínez <julian.martinez@piksel.com>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2019

k8s-ci-robot requested review from Raffo and njuettner April 28, 2019 08:45

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2019

k8s-ci-robot assigned Raffo Apr 28, 2019

alfredkrohmer mentioned this pull request Apr 28, 2019

Add ready-pods-only annotation #901

Closed

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 2b14f6f to 94fa80f Compare April 28, 2019 16:33

Raffo reviewed Jul 22, 2019

View reviewed changes

source/service.go Outdated Show resolved Hide resolved

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2019

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 623b15c to 9e43d65 Compare August 23, 2019 11:13

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2019

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 9e43d65 to 6546c9e Compare September 17, 2019 07:23

alfredkrohmer mentioned this pull request Sep 24, 2019

question: feedback on health check implementation for multi cluster traffic with AWS provider #1203

Closed

nikhita unassigned Raffo Oct 30, 2019

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 1535588 to 36f7984 Compare November 24, 2019 08:17

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2019

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 23dfd7b to 8882900 Compare December 13, 2019 16:18

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2019

alfredkrohmer changed the title ~~[RFC] Headless service: retrieve endpoints via Endpoints resource; evaluate spec.publishNotReadyAddresses~~ Headless service: retrieve endpoints via Endpoints resource; evaluate spec.publishNotReadyAddresses Dec 23, 2019

njuettner suggested changes Feb 18, 2020

View reviewed changes

source/service.go Outdated Show resolved Hide resolved

source/service_test.go Outdated Show resolved Hide resolved

docs/tutorials/alibabacloud.md Outdated Show resolved Hide resolved

alfredkrohmer and others added 4 commits February 18, 2020 19:41

Add CLI option to always publish not ready addresses of headless serv…

6cab35b

…ices

Fix typo

9343fb2

Update documentation to include RBAC permissions for endpoints resources

c91eae9

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 0860c23 to 85bf10a Compare February 18, 2020 18:59

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2020

Address review comments

65208db

alfredkrohmer force-pushed the feature/headless-services-publishnotreadyaddresses branch from 85bf10a to 65208db Compare February 18, 2020 19:19

njuettner approved these changes Feb 21, 2020

View reviewed changes

k8s-ci-robot requested review from Raffo and linki February 21, 2020 14:27

k8s-ci-robot assigned njuettner Feb 21, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020

k8s-ci-robot merged commit a563022 into kubernetes-sigs:master Mar 4, 2020

julian3xl added a commit to julian3xl/charts that referenced this pull request Mar 11, 2020

adding endpoints resource permissions

ae8c183

as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it

julian3xl mentioned this pull request Mar 11, 2020

adding endpoints resource permissions helm/charts#21419

Closed

4 tasks

julian3xl mentioned this pull request Mar 11, 2020

[bitnami/external-dns] adding endpoints resource permissions bitnami/charts#2035

Merged

4 tasks

ivankatliarchuk mentioned this pull request Jul 7, 2025

fix(source/service): make sure only unique targets available for futher processing #5614

Merged

3 tasks

Conversation

alfredkrohmer commented Apr 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alfredkrohmer commented Apr 28, 2019

Uh oh!

alfredkrohmer commented Apr 28, 2019

Uh oh!

alfredkrohmer commented Jun 8, 2019

Uh oh!

Raffo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alfredkrohmer commented Aug 23, 2019

Uh oh!

alfredkrohmer commented Sep 17, 2019

Uh oh!

judofyr commented Oct 30, 2019

Uh oh!

alfredkrohmer commented Nov 24, 2019

Uh oh!

vivekgarg20 commented Dec 9, 2019

Uh oh!

ashley commented Jan 17, 2020

Uh oh!

njuettner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

njuettner left a comment

Choose a reason for hiding this comment

Uh oh!

njuettner commented Mar 4, 2020

Uh oh!

k8s-ci-robot commented Mar 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alfredkrohmer commented Apr 28, 2019 •

edited

Loading