adding endpoints resource permissions#21419
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: julian3xl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @julian3xl. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
|
/assign @juan131 |
Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
|
any news here? this chart is broken right now using headless, could you please merge this if you're happy with it? |
|
Hi @julian3xl , Also, note the PR should start with |
|
Hi miguel, I also did it there bitnami/charts#2035 but it seems nobody is handling requests there, and this is an urgent patch I guess :( |
|
I'm closing this PR because @miguelaeh merged it on the new repository. Thanks so much!!! |
as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it
Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])