Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

adding endpoints resource permissions#21419

Closed
julian3xl wants to merge 4 commits intohelm:masterfrom
julian3xl:master
Closed

adding endpoints resource permissions#21419
julian3xl wants to merge 4 commits intohelm:masterfrom
julian3xl:master

Conversation

@julian3xl
Copy link
Copy Markdown

@julian3xl julian3xl commented Mar 11, 2020

as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: julian3xl
To complete the pull request process, please assign juan131
You can assign the PR to them by writing /assign @juan131 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @julian3xl. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

as described in kubernetes-sigs/external-dns#1005 now external-dns uses endpoints resource so it needs permissions to do it

Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Mar 11, 2020
Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Mar 11, 2020
@julian3xl
Copy link
Copy Markdown
Author

/assign @juan131

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Mar 11, 2020
Signed-off-by: Julián Martínez <julian.martinez@piksel.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Mar 11, 2020
@julian3xl
Copy link
Copy Markdown
Author

any news here? this chart is broken right now using headless, could you please merge this if you're happy with it?

@miguelaeh
Copy link
Copy Markdown
Collaborator

miguelaeh commented Mar 12, 2020

Hi @julian3xl ,
Thank you very much for the PR, as you can see here: https://github.com/helm/charts/tree/master/stable/external-dns#this-helm-chart-is-deprecated, this helm chart has been deprecated, could you open the PR at https://github.com/bitnami/charts instead, please?

Also, note the PR should start with [bitnami/external-dns]
Regards

@julian3xl
Copy link
Copy Markdown
Author

Hi miguel, I also did it there bitnami/charts#2035 but it seems nobody is handling requests there, and this is an urgent patch I guess :(

@julian3xl
Copy link
Copy Markdown
Author

I'm closing this PR because @miguelaeh merged it on the new repository. Thanks so much!!!

@julian3xl julian3xl closed this Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants