Add ready-pods-only annotation#901
Add ready-pods-only annotation#901alfredkrohmer wants to merge 2 commits intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This closes #878. |
|
/assign @linki |
source/service.go
Outdated
There was a problem hiding this comment.
I don't know if this makes sense to check the annotation from a service for each pod again and again.
I think this needs to be solved in a better way, WDYT?
There was a problem hiding this comment.
Good point, I will pull it out of the loop.
This annotation can be used to only register IPs of pods that are in "Ready" state (instead of the default behavior of registering all running pods) in DNS.
e904a3c to
ff7d1e1
Compare
|
@devkid can you please resolve the conflict? @njuettner Apart from the conflicts, the changes look good to me, are there any other reasons why we were waiting to move forward with this PR? |
|
@Raffo See @nmiculinic's comment in #878. I want to implement this in a different way (which actually makes more sense). I'll follow up today. |
This annotation can be used to only register IPs of pods that are in
"Ready" state (instead of the default behavior of registering all
running pods) in DNS.