Skip to content

Add ready-pods-only annotation#901

Closed
alfredkrohmer wants to merge 2 commits intokubernetes-sigs:masterfrom
alfredkrohmer:feature/headless-service-ready-pods-only
Closed

Add ready-pods-only annotation#901
alfredkrohmer wants to merge 2 commits intokubernetes-sigs:masterfrom
alfredkrohmer:feature/headless-service-ready-pods-only

Conversation

@alfredkrohmer
Copy link
Copy Markdown
Contributor

This annotation can be used to only register IPs of pods that are in
"Ready" state (instead of the default behavior of registering all
running pods) in DNS.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linki

If they are not already assigned, you can assign the PR to them by writing /assign @linki in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2019
@alfredkrohmer
Copy link
Copy Markdown
Contributor Author

This closes #878.

@alfredkrohmer
Copy link
Copy Markdown
Contributor Author

/assign @linki

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this makes sense to check the annotation from a service for each pod again and again.
I think this needs to be solved in a better way, WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will pull it out of the loop.

This annotation can be used to only register IPs of pods that are in
"Ready" state (instead of the default behavior of registering all
running pods) in DNS.
@alfredkrohmer alfredkrohmer force-pushed the feature/headless-service-ready-pods-only branch from e904a3c to ff7d1e1 Compare March 15, 2019 19:29
@Raffo
Copy link
Copy Markdown
Contributor

Raffo commented Apr 26, 2019

@devkid can you please resolve the conflict?

@njuettner Apart from the conflicts, the changes look good to me, are there any other reasons why we were waiting to move forward with this PR?

@alfredkrohmer
Copy link
Copy Markdown
Contributor Author

@Raffo See @nmiculinic's comment in #878. I want to implement this in a different way (which actually makes more sense). I'll follow up today.

@alfredkrohmer
Copy link
Copy Markdown
Contributor Author

alfredkrohmer commented Apr 28, 2019

@Raffo superseded by #1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants