📖 List ROSAMachinePool implementation in docs, improve implementation docs links #12797
Conversation
k8s-ci-robot
added
area/documentation
k8s-ci-robot
added
the
size/S
|
/approve Will leave lgtm to MachinePool reviewers |
k8s-ci-robot
added
the
approved
sbueringer
changed the title
| | [AWS](https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html) | `AWSManagedMachinePool`<br> `AWSMachinePool`<br>`ROSAMachinePool` | Implemented, MachinePoolMachines supported | | ||
| | [Azure](https://capz.sigs.k8s.io/self-managed/machinepools) | `AzureASOManagedMachinePool`<br> `AzureManagedMachinePool`<br> `AzureMachinePool` | Implemented, MachinePoolMachines supported | | ||
| | [GCP](https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1506) | `GCPMachinePool` | In Progress | | ||
| | [OCI](https://oracle.github.io/cluster-api-provider-oci/managed/managedcluster.html) | `OCIManagedMachinePool`<br> `OCIMachinePool` | Implemented, MachinePoolMachines supported | |
There was a problem hiding this comment.
q: should we document when a provider support deletion of single MPM (IIRC a few feature depend on this, like e.g. the capability to use MHC)
Note. this can be added also as a follow up if you prefer
There was a problem hiding this comment.
It would be good to do that. Shall we do that as a follow-up?
There was a problem hiding this comment.
@richardcase PR was merged, if you think this suggestion if it brings value, I would suggest to add it to the tracking issue
There was a problem hiding this comment.
I just added that suggestion in #12872
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @mboersma @richardcase Would be good if one of you can review this one as well |
| | [AWS](https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html) | `AWSManagedMachinePool`<br> `AWSMachinePool`<br>`ROSAMachinePool` | Implemented, MachinePoolMachines supported | | ||
| | [Azure](https://capz.sigs.k8s.io/self-managed/machinepools) | `AzureASOManagedMachinePool`<br> `AzureManagedMachinePool`<br> `AzureMachinePool` | Implemented, MachinePoolMachines supported | | ||
| | [GCP](https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1506) | `GCPMachinePool` | In Progress | | ||
| | [OCI](https://oracle.github.io/cluster-api-provider-oci/managed/managedcluster.html) | `OCIManagedMachinePool`<br> `OCIMachinePool` | Implemented, MachinePoolMachines supported | |
There was a problem hiding this comment.
It would be good to do that. Shall we do that as a follow-up?
| | Scaleway | `ScalewayManagedMachinePool` | Implemented | https://github.com/scaleway/cluster-api-provider-scaleway/blob/main/docs/scalewaymanagedmachinepool.md | | ||
| | Provider | Implementations | Status | | ||
| | --- | --- | --- | | ||
| | [AWS](https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html) | `AWSManagedMachinePool`<br> `AWSMachinePool`<br>`ROSAMachinePool` | Implemented, MachinePoolMachines supported | |
There was a problem hiding this comment.
Great that ROSAMacvhinePool was added.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5d43b1cffbff6ec948a18d3205baa4c60e92889c
|
6 participants
What this PR does / why we need it:
Follow-up for #12777 in the machine pool working group.
Raw links didn't get rendered, so I've linked them to the first column. Added
ROSAMachinePool(part of CAPA codebase)./area documentation
/area machinepool