-
Couldn't load subscription status.
- Fork 1.4k
📖 List provider implementations of MachinePools #12777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 List provider implementations of MachinePools #12777
Conversation
|
/cc @richardcase |
|
Thx! Feel free to merge once you have all the reviews you want |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to use the name listed in the provider list, but no strong preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for doing this @mboersma.
It would be good to add CAPG into the list as there is an implementation in progress.
3b7b4bf to
111bdc6
Compare
|
I updated the providers to match how they're described elsewhere in the docs, noted that OCI supports MPMs, and added a section for the GCP implementation in progress. Thanks everyone for the helpful feedback! |
|
Thank you! Looks good to me. /lgtm |
|
LGTM label has been added. Git tree hash: 2fa1200b49f0155bdffb7b15c5db5591f8f9b8a8
|
111bdc6 to
7beac7a
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 9ebdd41adf5a94f184f594b4d518bb063160db04
|
|
/hold cancel |
What this PR does / why we need it:
Adds a markdown table of known implementors of
MachinePool.This was a task we talked about at the first MP working group meeting. I visited all listed provider repos and grepped for
MachinePool. (I hear GCP has an implementation in progress as well.)Which issue(s) this PR fixes:
Refs #9005
/area documentation
/area machinepool