:bug: Fix Provisioning to Unavailable AZs by spjmurray · Pull Request #1479 · kubernetes-sigs/cluster-api-provider-openstack

spjmurray · 2023-02-17T10:10:52Z

CAPO uses any ZA it finds, rather than checking whether the ZA is actually available, meaning you can get into a state where it's impossible to provision a cluster. This allows clients to filter based on AZ availability before scheduling.

Fixes #1477

What this PR does / why we need it:

Discussion in #1477

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

[x ] squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

netlify · 2023-02-17T10:10:56Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`b05c247`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63f374677c88810008cce09f
😎 Deploy Preview	https://deploy-preview-1479--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2023-02-17T10:11:01Z

Hi @spjmurray. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lentzi90

/ok-to-test

pkg/cloud/services/compute/availabilityzone.go

lentzi90 · 2023-02-17T12:49:29Z

Could you please fix the commit message and check the linter error (make lint-update should do it)?

mdbooth

Looks good in principal. Just need to update the unit tests for the webhook change and to avoid creating dead code in availabilityzones.go.

api/v1alpha6/openstackcluster_webhook.go

pkg/cloud/services/compute/availabilityzone.go

CAPO uses any ZA it finds, rather than checking whether the ZA is actually available, meaning you can get into a state where it's impossible to provision a cluster. This allows clients to filter based on AZ availability before scheduling.

mdbooth · 2023-02-20T14:20:18Z

/approve

Thanks! I'll leave lgtm to another reviewer.

k8s-ci-robot · 2023-02-20T14:20:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, spjmurray

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lentzi90

/lgtm

mdbooth · 2023-02-21T10:13:04Z

@spjmurray If you cancel the hold this will merge.

mdbooth · 2023-02-21T10:13:15Z

/cherry-pick release-0.7

k8s-infra-cherrypick-robot · 2023-02-21T10:13:16Z

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spjmurray · 2023-02-22T10:27:44Z

/hold cancel

k8s-infra-cherrypick-robot · 2023-02-22T10:28:36Z

@mdbooth: new pull request created: #1488

Details

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Feb 17, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2023

k8s-ci-robot requested review from lentzi90 and mdbooth February 17, 2023 10:10

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2023

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2023

lentzi90 reviewed Feb 17, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2023

lentzi90 reviewed Feb 17, 2023

View reviewed changes

pkg/cloud/services/compute/availabilityzone.go Outdated Show resolved Hide resolved

mdbooth suggested changes Feb 20, 2023

View reviewed changes

api/v1alpha6/openstackcluster_webhook.go Show resolved Hide resolved

pkg/cloud/services/compute/availabilityzone.go Outdated Show resolved Hide resolved

Fix Provisioning to Unavailable AZs

b05c247

CAPO uses any ZA it finds, rather than checking whether the ZA is actually available, meaning you can get into a state where it's impossible to provision a cluster. This allows clients to filter based on AZ availability before scheduling.

spjmurray force-pushed the fix_azs branch from 7ed7773 to b05c247 Compare February 20, 2023 13:23

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023

lentzi90 reviewed Feb 20, 2023

View reviewed changes

k8s-ci-robot assigned lentzi90 Feb 20, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023

k8s-ci-robot merged commit f9b7a5d into kubernetes-sigs:main Feb 22, 2023

k8s-infra-cherrypick-robot mentioned this pull request Feb 22, 2023

[release-0.7] 🐛 Fix Provisioning to Unavailable AZs #1488

Merged

spjmurray deleted the fix_azs branch February 22, 2023 13:22

Conversation

spjmurray commented Feb 17, 2023

Uh oh!

netlify bot commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

k8s-ci-robot commented Feb 17, 2023

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lentzi90 commented Feb 17, 2023

Uh oh!

mdbooth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mdbooth commented Feb 20, 2023

Uh oh!

k8s-ci-robot commented Feb 20, 2023

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

mdbooth commented Feb 21, 2023

Uh oh!

mdbooth commented Feb 21, 2023

Uh oh!

k8s-infra-cherrypick-robot commented Feb 21, 2023

Uh oh!

spjmurray commented Feb 22, 2023

Uh oh!

k8s-infra-cherrypick-robot commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Feb 17, 2023 •

edited

Loading