Skip to content

🐛 fix tests in release-0.5#1208

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:release-0.5from
apricote:release-0.5-cherry-pick-1184
Apr 19, 2022
Merged

🐛 fix tests in release-0.5#1208
k8s-ci-robot merged 2 commits intokubernetes-sigs:release-0.5from
apricote:release-0.5-cherry-pick-1184

Conversation

@apricote
Copy link
Member

@apricote apricote commented Apr 14, 2022

What this PR does / why we need it:

Fixes tests in release-0.5 by backporting following prs:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

With versions lower than 1.45.0, golangci-lint returns a lot of invalid
errors when running in Go 1.18+.

This commit upgrades golangci-lint to the latest released version and fixes
all linting errors that came up.

Includes changes from #1042, #1082 and #1184 to succesfully lint.
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 024e32f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6258142565fa6900084f4a6c
😎 Deploy Preview https://deploy-preview-1208--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 14, 2022
@jichenjc
Copy link
Contributor

/lgtm

it's a reasonable backport, thanks~

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@apricote
Copy link
Member Author

/retitle 🐛 fix tests in release-0.5

@k8s-ci-robot k8s-ci-robot changed the title 🐛 upgrade golangci-lint for go 1.18 support 🐛 fix tests in release-0.5 Apr 14, 2022
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2022
@tobiasgiese
Copy link
Member

/approve

Thanks! 👌🏻

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit fb450fd into kubernetes-sigs:release-0.5 Apr 19, 2022
@apricote apricote deleted the release-0.5-cherry-pick-1184 branch April 19, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants