✨ Bump golangci-lint to 1.43.0#1042
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Nov 19, 2021
stmcginnis:golangci-lint
Merged
✨ Bump golangci-lint to 1.43.0#1042k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom stmcginnis:golangci-lint
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
stmcginnis:golangci-lint
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: f94f074 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61952a8407ac5600088665f0 😎 Browse the preview: https://deploy-preview-1042--kubernetes-sigs-cluster-api-openstack.netlify.app |
k8s-ci-robot
added
size/L
This version of golangci-lint picks up some updated linters. This provides better checks, and also addresses an issue some had when running under go 1.17. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
k8s-ci-robot
added
size/L
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hidekazuna, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This version of golangci-lint picks up some updated linters. This
provides better checks, and also addresses an issue some had when
running under go 1.17.
Special notes for your reviewer:
Can be tested locally by running
make lint.TODOs: