🌱 Standardize api import aliases#1082
Conversation
Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
|
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 5bc8650 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61b229afb8b8a4000722ae7b 😎 Browse the preview: https://deploy-preview-1082--kubernetes-sigs-cluster-api-openstack.netlify.app |
|
/lgtm |
seanschneeweiss
left a comment
There was a problem hiding this comment.
/lgtm
Sean Schneeweiss sean.schneeweiss@daimler.com, Daimler TSS GmbH, Provider Information
|
I need also an approve, as this PR was created before I was added to the maintainers list 😿 /hold cancel |
|
/approve 2 lgtm now ~ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):This PR standardizes our API import aliases. Further, it removes to skip lint our conversion.go files.
Adopted from kubernetes-sigs/cluster-api#5830
Follow-up of Slack discussion https://kubernetes.slack.com/archives/CFKJB65G9/p1639063415164300
Special notes for your reviewer:
TODOs:
/hold
Tobias Giese tobias.giese@daimler.com, Daimler TSS GmbH, legal info/Impressum