Skip to content

🌱 Standardize api import aliases#1082

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
mercedes-benz:pr-standardize-api-import-aliases
Dec 14, 2021
Merged

🌱 Standardize api import aliases#1082
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
mercedes-benz:pr-standardize-api-import-aliases

Conversation

@tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Dec 9, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

This PR standardizes our API import aliases. Further, it removes to skip lint our conversion.go files.
Adopted from kubernetes-sigs/cluster-api#5830
Follow-up of Slack discussion https://kubernetes.slack.com/archives/CFKJB65G9/p1639063415164300

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese tobias.giese@daimler.com, Daimler TSS GmbH, legal info/Impressum

Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2021
@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 5bc8650

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61b229afb8b8a4000722ae7b

😎 Browse the preview: https://deploy-preview-1082--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2021
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
Copy link
Contributor

@seanschneeweiss seanschneeweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Sean Schneeweiss sean.schneeweiss@daimler.com, Daimler TSS GmbH, Provider Information

@tobiasgiese
Copy link
Member Author

I need also an approve, as this PR was created before I was added to the maintainers list 😿

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2021
@jichenjc
Copy link
Contributor

/approve

2 lgtm now ~

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jichenjc,tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit b936d98 into kubernetes-sigs:main Dec 14, 2021
@mdbooth mdbooth mentioned this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants