Skip to content

🐛 [v0.5.0] Prevent creation of floating IPs when reconcile load balancer in non ACTIVE state #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Mar 10, 2022
Merged

🐛 [v0.5.0] Prevent creation of floating IPs when reconcile load balancer in non ACTIVE state #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/cloud/services/loadbalancer/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const (
kubeapiLBSuffix string = "kubeapi"
)

const loadBalancerProvisioningStatusActive = "ACTIVE"

func (s *Service) ReconcileLoadBalancer(openStackCluster *infrav1.OpenStackCluster, clusterName string, apiServerPort int) error {
loadBalancerName := getLoadBalancerName(clusterName)
s.logger.Info("Reconciling load balancer", "name", loadBalancerName)
Expand All @@ -56,6 +58,9 @@ func (s *Service) ReconcileLoadBalancer(openStackCluster *infrav1.OpenStackClust
if err != nil {
return err
}
if lb.ProvisioningStatus != loadBalancerProvisioningStatusActive {
return fmt.Errorf("load balancer %q is not in expected state %s, current state is %s", lb.ID, loadBalancerProvisioningStatusActive, lb.ProvisioningStatus)
}

var lbFloatingIP string
if !openStackCluster.Spec.DisableAPIServerFloatingIP {
Expand Down Expand Up @@ -524,7 +529,7 @@ var backoff = wait.Backoff{
Jitter: 0.1,
}

// Possible LoadBalancer states are documented here: https://developer.openstack.org/api-ref/network/v2/?expanded=show-load-balancer-status-tree-detail#load-balancer-statuses
// Possible LoadBalancer states are documented here: https://docs.openstack.org/api-ref/load-balancer/v2/index.html#prov-status
func (s *Service) waitForLoadBalancerActive(id string) error {
s.logger.Info("Waiting for load balancer", "id", id, "targetStatus", "ACTIVE")
return wait.ExponentialBackoff(backoff, func() (bool, error) {
Expand All @@ -533,7 +538,7 @@ func (s *Service) waitForLoadBalancerActive(id string) error {
if mc.ObserveRequest(err) != nil {
return false, err
}
return lb.ProvisioningStatus == "ACTIVE", nil
return lb.ProvisioningStatus == loadBalancerProvisioningStatusActive, nil
})
}

Expand Down