Skip to content

Update .golangci.yml#1090

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
mercedes-benz:caas/tobgies/update-golangci-lint-conf
Dec 15, 2021
Merged

Update .golangci.yml#1090
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
mercedes-benz:caas/tobgies/update-golangci-lint-conf

Conversation

@tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Dec 15, 2021

We're using still Go 1.16. Accidentally updated with #1082, which was definitely not on purpose.

Tobias Giese tobias.giese@daimler.com, Daimler TSS GmbH, legal info/Impressum

@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: db20396

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61ba0ccfcc62f800073efa09

😎 Browse the preview: https://deploy-preview-1090--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2021
Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
@tobiasgiese tobiasgiese force-pushed the caas/tobgies/update-golangci-lint-conf branch from 6820357 to db20396 Compare December 15, 2021 15:42
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@chrischdi
Copy link
Member

damnit, I have to
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit cae0423 into kubernetes-sigs:main Dec 15, 2021
@tobiasgiese tobiasgiese deleted the caas/tobgies/update-golangci-lint-conf branch December 16, 2021 08:56
@mdbooth mdbooth mentioned this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants