Update virtualmachineimages service to SDK v2

[willie-yao]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates the virtualmachineimages service to use SDK v2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3569
Fixes #3473

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Update virtualmachineimages service to SDK v2

[willie-yao]

/assign @mboersma

[k8s-ci-robot]

@willie-yao: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@willie-yao: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jont828]

@willie-yao Looks like you got a failing test btw

[Jont828]

/assign

[codecov]

Codecov Report

Patch coverage: 29.48% and project coverage change: -0.09% ⚠️

Comparison is base (2789eae) 55.49% compared to head (0a9e100) 55.41%.
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3843      +/-   ##
==========================================
- Coverage   55.49%   55.41%   -0.09%     
==========================================
  Files         188      189       +1     
  Lines       19456    19396      -60     
==========================================
- Hits        10797    10748      -49     
+ Misses       8057     8046      -11     
  Partials      602      602              

Files Changed	Coverage Δ
azure/scope/clients.go	44.55% <0.00%> (-3.32%)	⬇️
azure/scope/cluster.go	56.81% <ø> (ø)
azure/scope/identity.go	35.71% <0.00%> (-1.50%)	⬇️
azure/scope/machinepool.go	29.43% <0.00%> (-2.01%)	⬇️
azure/scope/machine.go	50.40% <25.00%> (-0.42%)	⬇️
azure/services/virtualmachineimages/client.go	30.76% <36.36%> (-19.24%)	⬇️
azure/services/virtualmachineimages/images.go	81.95% <41.66%> (-2.43%)	⬇️
azure/services/virtualmachineimages/cache.go	75.40% <64.28%> (-7.93%)	⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

@willie-yao do you think it would be worth splitting this into two commits? One for the auth changes under azure/scope, another with everything else for the virtualmachineimages service. Just because it might make it easier to review now (and in the future, since several SDKv2 tasks might want to refer to this).

Just an idea, please ignore if it sounds like a hassle.

[willie-yao]

do you think it would be worth splitting this into two commits?

@mboersma Done!!

[Jont828]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 10b5c338ce6231f1c03f23f7fedd8db2b9ccbfce

[mboersma]

/lgtm
/assign @CecileRobertMichon

[CecileRobertMichon]

LGTM

Can we update code comments in the modified interfaces to account for the added Token() func? It would be also helpful to make the distinction that Authorizer is used by sdk v1 services while Token is used by sdk v2 services in code comments as the redundancy might be confusing to a future reader

[CecileRobertMichon]

/lgtm
/approve

Great work @willie-yao, I like the simple and elegant solution you ended up with!

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: cb3ba262023a1334807a70c4f156b7a9394602b5

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Jont828]

/lgtm