[WIP] Update virtualmachineimages service to SDK v2

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the virtualmachineimages service to use SDK v2.

Which issue(s) this PR fixes:

Fixes #3569
Fixes #3473

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Update virtualmachineimages service to SDK v2

[mboersma]

/retitle [WIP] Update virtualmachineimages service to SDK v2

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Patch coverage: 32.10% and project coverage change: -0.20% ⚠️

Comparison is base (668a1bc) 54.35% compared to head (d74e70b) 54.16%.
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3758      +/-   ##
==========================================
- Coverage   54.35%   54.16%   -0.20%     
==========================================
  Files         187      187              
  Lines       18998    19167     +169     
==========================================
+ Hits        10326    10381      +55     
- Misses       8115     8218     +103     
- Partials      557      568      +11     

Files Changed	Coverage Δ
azure/scope/cluster.go	56.59% <0.00%> (-0.22%)	⬇️
azure/scope/managedcontrolplane.go	24.16% <0.00%> (-0.16%)	⬇️
controllers/azurecluster_controller.go	37.07% <0.00%> (ø)
controllers/azuremanagedcontrolplane_controller.go	20.60% <0.00%> (ø)
controllers/helpers.go	54.69% <0.00%> (ø)
azure/scope/machine.go	50.30% <20.00%> (-0.52%)	⬇️
azure/defaults.go	32.17% <28.28%> (-1.42%)	⬇️
azure/services/virtualmachineimages/images.go	81.81% <36.36%> (-2.56%)	⬇️
azure/services/virtualmachineimages/client.go	32.35% <36.66%> (-17.65%)	⬇️
azure/scope/machinepool.go	31.26% <40.00%> (-0.18%)	⬇️
... and 2 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[k8s-ci-robot]

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	d74e70b	link	false	/test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[willie-yao]

/close
In favor of #3843

[k8s-ci-robot]

@willie-yao: Closed this PR.

Details

In response to this:

/close
In favor of #3843

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.