Convert managedclusters service to SDKv2

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Converts the managedclusters service and the agentpools service to use SDKv2 and the asyncpoller framework for long-running operations.

Which issue(s) this PR fixes:

Fixes #3861
Refs #3409

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[mboersma]

/retitle [WIP] Convert managedclusters service to SDKv2

There are still a couple // TODOs here, it needs to be rebased on #3843, and there is an issue where the AzureManagedCluster stays in Provisioning state although the infrastructure is actually ready.

[codecov]

Codecov Report

Patch coverage: 40.21% and project coverage change: +0.18% 🎉

Comparison is base (b709abf) 55.59% compared to head (3965331) 55.77%.

❗ Current head 3965331 differs from pull request most recent head 9fd45ec. Consider uploading reports for the commit 9fd45ec to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3857      +/-   ##
==========================================
+ Coverage   55.59%   55.77%   +0.18%     
==========================================
  Files         190      190              
  Lines       19507    19475      -32     
==========================================
+ Hits        10844    10863      +19     
+ Misses       8056     8004      -52     
- Partials      607      608       +1     

Files Changed	Coverage Δ
azure/services/agentpools/client.go	0.00% <0.00%> (ø)
azure/services/managedclusters/client.go	0.00% <0.00%> (ø)
controllers/azuremanagedcontrolplane_controller.go	40.66% <0.00%> (ø)
controllers/azuremanagedmachinepool_controller.go	55.00% <0.00%> (ø)
controllers/azuremanagedmachinepool_reconciler.go	53.06% <0.00%> (-2.26%)	⬇️
azure/services/agentpools/agentpools.go	69.38% <23.07%> (-6.17%)	⬇️
azure/services/managedclusters/managedclusters.go	73.13% <23.07%> (-4.65%)	⬇️
azure/services/managedclusters/spec.go	50.49% <43.79%> (-0.13%)	⬇️
controllers/azuremanagedcontrolplane_reconciler.go	38.02% <50.00%> (-0.21%)	⬇️
azure/services/agentpools/spec.go	59.31% <71.42%> (-1.17%)	⬇️
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CecileRobertMichon]

/lgtm
/hold for squash

[CecileRobertMichon]

/hold cancel
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 054bbe9c9f424f530ac6075b88758a75b60a5882

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/hold cancel

[CecileRobertMichon]

/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts

flake

[mboersma]

/hold

The AKS is test is taking an unusually long time, so even if it passes I'd like to verify that it's an outlier.

[mboersma]

/retest

[mboersma]

/test pull-cluster-api-provider-azure-e2e-aks

Let's see another green run.

[CecileRobertMichon]

last aks run failed

/retest

[CecileRobertMichon]

/test pull-cluster-api-provider-azure-e2e-aks

[CecileRobertMichon]

@mboersma I checked the two previous e2e failures, they happened at two different places in the test so I don't think there's a pattern

[mboersma]

/hold cancel