Skip to content

Add cloud-provider-azure ref to build-win-soak-tests job#29110

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
oprinmarius:update_soak-tests
Mar 22, 2023
Merged

Add cloud-provider-azure ref to build-win-soak-tests job#29110
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
oprinmarius:update_soak-tests

Conversation

@oprinmarius
Copy link
Copy Markdown

@oprinmarius oprinmarius commented Mar 22, 2023 •
edited
Loading

The Windows Soak tests jobs are failing after this PR has been merged:
kubernetes-sigs/cluster-api-provider-azure#3233

The build-win-soak-test-cluster job is using KUBERNETES_VERSION=latest which triggers the AZURE CCM build: https://github.com/CecileRobertMichon/cluster-api-provider-azure/blob/4a7b93d0a5f8170874559e8c4c0760ea0e3a4f41/hack/util.sh#L53-L56

This PR adds cloud-provider-azure as an extra_ref to the build-win-soak-test-cluster job, required for building Azure CCM

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Mar 22, 2023
@oprinmarius
Copy link
Copy Markdown
Author

oprinmarius commented Mar 22, 2023

/assign @marosset

@jsturtevant
Copy link
Copy Markdown
Contributor

jsturtevant commented Mar 22, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, oprinmarius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit fc8d3b9 into kubernetes:master Mar 22, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 22, 2023

@oprinmarius: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key soak-tests.yaml using file config/jobs/kubernetes-sigs/sig-windows/soak-tests.yaml
Details

In response to this:

The Windows Soak tests jobs are failing after this PR has been merged:
kubernetes-sigs/cluster-api-provider-azure#3233

The build-win-soak-test-cluster job is using KUBERNETES_VERSION=latest which triggers the AZURE CCM build: https://github.com/CecileRobertMichon/cluster-api-provider-azure/blob/4a7b93d0a5f8170874559e8c4c0760ea0e3a4f41/hack/util.sh#L53-L56

This PR adds cloud-provider-azure as an extra_ref to the build-win-soak-test-cluster job, required for building Azure CCM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oprinmarius oprinmarius changed the title Add cluster-provider-azure ref to build-win-soak-tests job Add cloud-provider-azure ref to build-win-soak-tests job Mar 24, 2023
@oprinmarius oprinmarius deleted the update_soak-tests branch March 24, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@jsturtevant jsturtevant

@marosset marosset

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

[sig-windows] PR tracking
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oprinmarius @jsturtevant @k8s-ci-robot @marosset