Increase deloyment timeout in e2e to accommodate Windows deployments#1326
Merged
k8s-ci-robot merged 1 commit intoApr 20, 2021
Merged
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
Contributor
|
related to #1315 was hoping 8 minutes would be enough but looks like not... |
Contributor
Author
In my experience fresh windows image pull can take 12-15 mins. We shouldn't being pull a completely fresh Windows image (nano should already be on the node) but outliers in the pull might be taking while. |
Contributor
|
/lgtm 🤞 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
The windows pod sometimes takes longer to come online. Logs indicate it pulling was still in progress.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/1119/pull-cluster-api-provider-azure-e2e-windows/1384286383429914624
Wait for resources and don't use envsubst in tilt #1294 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
We could have a separate timeout for Windows, but added more complexity to implement.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: