Skip to content

[backport] Increase timeout to accommodate windows deployments#1346

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-0.4from
nader-ziada:deployment-timeout
Apr 28, 2021
Merged

[backport] Increase timeout to accommodate windows deployments#1346
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-0.4from
nader-ziada:deployment-timeout

Conversation

@nader-ziada
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind flake

What this PR does / why we need it:
backport of #1326

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

this won't completely fix it (see #1328) but it might reduce number of flakes

/retest
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9de90bd into kubernetes-sigs:release-0.4 Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.15 milestone Apr 28, 2021
willie-yao pushed a commit to willie-yao/cluster-api-provider-azure that referenced this pull request Jul 11, 2025
Co-authored-by: Vikram Chandramohan <vikramcha@microsoft.com>
Co-authored-by: slfletch <staceylynnfletcher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants