Skip to content

Increase wait-deployment timeout#1315

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
CecileRobertMichon:deploy-timeout
Apr 16, 2021
Merged

Increase wait-deployment timeout#1315
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
CecileRobertMichon:deploy-timeout

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon commented Apr 15, 2021

What type of PR is this?
/kind failing-test

What this PR does / why we need it: Increase the E2E deployment timeout as the web-windows deploy regularly times out and causes flakes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1284

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

/hold

for test retries

@k8s-ci-robot k8s-ci-robot requested review from cpanato and shysank April 15, 2021 15:43
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 15, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

passed 1/1

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

passed 2/2

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

failed to create kind cluster with error msg: "failed to pull image \"kindest/node:v1.19.1\"",

Ugly errror but unrelated to what we're testing here

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 15, 2021
Merged
3 tasks
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

passed 3/3

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

passed 4/4

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

passed 5/5

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

passed 6/6

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 15, 2021

Node failed to come up, different flake

Timed out after 1200.001s.
Expected
    <int>: 0
to equal
    <int>: 1

/retest

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 16, 2021

Got 7 passes, 2 unrelated failure, 0 web-windows deployment timeout errors

Given the current job history (https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-cluster-api-provider-azure-e2e-windows), I think it's safe to say this greatly reduces the flakes observed in #1284, if not completely eliminate them.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
devigned
devigned approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit efd7005 into kubernetes-sigs:master Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Apr 16, 2021
@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 20, 2021
Merged
3 tasks
@CecileRobertMichon CecileRobertMichon deleted the deploy-timeout branch February 17, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@shysank shysank Awaiting requested review from shysank

1 more reviewer

@devigned devigned devigned approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@devigned devigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

E2E flake: Waiting for web-windows deployment times out

3 participants

@CecileRobertMichon @k8s-ci-robot @devigned