Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jsafrane
force-pushed
the
bump-1.21-rc0
branch
2 times, most recently
from
816a2a4 to
79d27bf
Compare
| ) | ||
|
|
||
| replace k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.20.0 | ||
| replace k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.21.0 |
There was a problem hiding this comment.
same question as resize PR. I think we don't need these replace statements if we're not importing k8s.io/kubernetes
There was a problem hiding this comment.
I have less faith in that. But we can try without them and then we'll see whether the default version selection for indirect dependencies will do a good enough job of selecting a consistent set of module versions.
There was a problem hiding this comment.
I tried it out on my local workspace and it seems fine?
There was a problem hiding this comment.
Fixed with the new release-tools.
bc0504ad Merge pull request kubernetes-csi#140 from jsafrane/remove-unused-k8s-libs 5b1de1ad go-get-kubernetes.sh: remove unused k8s libs 49b42693 Merge pull request kubernetes-csi#120 from pohly/add-kubernetes-release f7e7ee49 docs: steps for adding testing against new Kubernetes release git-subtree-dir: release-tools git-subtree-split: bc0504ad76ac6e20d0d7c60d46f62c7ff7591f8c
| ) | ||
|
|
||
| replace k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.20.0 | ||
| replace k8s.io/component-base => k8s.io/component-base v0.21.0 |
There was a problem hiding this comment.
Even then I think all of these replace statements can be removed.
There was a problem hiding this comment.
Then go get -u ./... no longer works. For example, it updates to k8s.io/client-go v1.5.2.
There was a problem hiding this comment.
+1 to Patrick, go mod is very confused when you remove those replaces.
There was a problem hiding this comment.
thanks. one day I will understand how vendoring works :-)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
90925279 Merge pull request kubernetes-csi#298 from torredil/trivy-schedule-trigger 2c9aed3e Merge pull request kubernetes-csi#299 from andyzhangx/patch-12 507ea1e9 chore: fix broken gcb-docker-gcloud image ab1da0e9 Run Trivy scan on schedule instead of pull requests de06a09a Merge pull request kubernetes-csi#297 from andyzhangx/patch-11 fc719f31 fix: Update Go version from 1.25.8 to 1.25.9 c24a730e Merge pull request kubernetes-csi#296 from jsafrane/pin-github-actions-sha 59b456b8 fix: pin github action to exact SHA 061f6eed Merge pull request kubernetes-csi#295 from kubernetes-csi/security/update-trivy-action-v0.35.0 6c16f30b security: Update trivy-action to v0.35.0 119a53c3 Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba fix: upgrade to go1.25.7 to fix CVE-2026-25679 git-subtree-dir: release-tools git-subtree-split: 909252797a11793b90f81c1aff9d181b4eebd363
4 participants
/kind cleanup
What this PR does / why we need it:
Update to the latest release-tools and rebase all Kubernetes libs to v1.21.0