Skip to content

update to Go 1.12.4#140

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
pohly:release-tools
Apr 15, 2019
Merged

update to Go 1.12.4#140
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
pohly:release-tools

Conversation

@pohly
Copy link
Copy Markdown
Contributor

@pohly pohly commented Apr 15, 2019

No description provided.

pohly added 2 commits April 15, 2019 09:45
@pohly
update to Go 1.12.4
e157b6b 
Kubernetes also requires 1.12. We pick the latest stable release
for CI builds.
@pohly
Merge commit 'e157b6b514ace191f46d4c879491cb7d11684659' into release-…
a4995d0 
…tools
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 15, 2019 08:51
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2019
@pohly pohly marked this pull request as ready for review April 15, 2019 09:03
@pohly
Copy link
Copy Markdown
Contributor Author

pohly commented Apr 15, 2019

/test pull-kubernetes-csi-external-attacher-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-external-attacher-1-13-on-kubernetes-master
/test pull-kubernetes-csi-external-attacher-1-14-on-kubernetes-1-14
/test pull-kubernetes-csi-external-attacher-1-14-on-kubernetes-master
/test pull-kubernetes-csi-external-attacher-alpha-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-external-attacher-alpha-1-14-on-kubernetes-1-14
/test pull-kubernetes-csi-external-attacher-unit

@pohly pohly changed the title WIP: update to Go 1.12.4 update to Go 1.12.4 Apr 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Apr 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 52fe6a1 into kubernetes-csi:master Apr 15, 2019
jsafrane added a commit to jsafrane/external-attacher that referenced this pull request Apr 15, 2021
@jsafrane
Squashed 'release-tools/' changes from a1e11275..bc0504ad
f9d31a6 
bc0504ad Merge pull request kubernetes-csi#140 from jsafrane/remove-unused-k8s-libs
5b1de1ad go-get-kubernetes.sh: remove unused k8s libs
49b42693 Merge pull request kubernetes-csi#120 from pohly/add-kubernetes-release
f7e7ee49 docs: steps for adding testing against new Kubernetes release

git-subtree-dir: release-tools
git-subtree-split: bc0504ad76ac6e20d0d7c60d46f62c7ff7591f8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pohly @k8s-ci-robot @msau42