Process PV finalizer for migrated PV when CSIMigration turned off#294
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Mar 18, 2021
Merged
Process PV finalizer for migrated PV when CSIMigration turned off#294k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/L
Contributor
Author
Contributor
Author
|
/cc @msau42 |
jsafrane
reviewed
Mar 17, 2021
| ignore = false | ||
| if ann := pv.Annotations; ann != nil { | ||
| if migratedToDriver := ann[annMigratedTo]; migratedToDriver == h.attacherName { | ||
| ignore = true |
Contributor
There was a problem hiding this comment.
It would be perhaps better to log a specific message + call pvQueue.Forget and return here. The message logged below is about deletion timestamp.
Contributor
Author
There was a problem hiding this comment.
Done. I think the deletion timestamp is related. I added a log to identify the scenario that we need to remove the anno
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
andyzhangx
added a commit
to andyzhangx/external-attacher
that referenced
this pull request
Apr 17, 2026
90925279 Merge pull request kubernetes-csi#298 from torredil/trivy-schedule-trigger 2c9aed3e Merge pull request kubernetes-csi#299 from andyzhangx/patch-12 507ea1e9 chore: fix broken gcb-docker-gcloud image ab1da0e9 Run Trivy scan on schedule instead of pull requests de06a09a Merge pull request kubernetes-csi#297 from andyzhangx/patch-11 fc719f31 fix: Update Go version from 1.25.8 to 1.25.9 c24a730e Merge pull request kubernetes-csi#296 from jsafrane/pin-github-actions-sha 59b456b8 fix: pin github action to exact SHA 061f6eed Merge pull request kubernetes-csi#295 from kubernetes-csi/security/update-trivy-action-v0.35.0 6c16f30b security: Update trivy-action to v0.35.0 119a53c3 Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba fix: upgrade to go1.25.7 to fix CVE-2026-25679 git-subtree-dir: release-tools git-subtree-split: 909252797a11793b90f81c1aff9d181b4eebd363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR removes PV external-attacher finalizer when CSIMigration is turned off. Without this change, the in-tree PV controller is not able to delete the PV object when there is no CSI driver in the cluster.
Which issue(s) this PR fixes:
Partially Fixes # kubernetes-csi/external-provisioner#576
Special notes for your reviewer:
This does not fix the issue if the corresponding CSI driver is uninstalled when CSI Migration is turned off. This fix is based on the assumption that CSI driver will still be around for at least a while to remove the finalizer.
Does this PR introduce a user-facing change?: