Update vendor to bring in updated CSI translation library#133
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Mar 28, 2019
Merged
Update vendor to bring in updated CSI translation library#133k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
Looks good but how about removing the various constraints tied to k8s versions in the gopkg.toml in a manner similar to https://github.com/kubernetes-csi/external-provisioner/commits/master/Gopkg.toml |
msau42
reviewed
Mar 27, 2019
| expectedCSICalls: []csiCall{ | ||
| {"attach", "projects/UNSPECIFIED/zones/testZone/disks/testpd", testNodeID, | ||
| map[string]string{"partition": "0"}, noSecrets, readWrite, success, notDetached, noMetadata, 0}, | ||
| map[string]string{"partition": ""}, noSecrets, readWrite, success, notDetached, noMetadata, 0}, |
Contributor
There was a problem hiding this comment.
It might be better to separate out this change into a separate commit in this PR (with the main commit focussing on the vendoring update).
Author
jsafrane
added a commit
to jsafrane/external-attacher
that referenced
this pull request
Mar 28, 2019
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pohly
added a commit
to pohly/external-attacher
that referenced
this pull request
Feb 3, 2021
7bc70e52 Merge pull request kubernetes-csi#129 from pohly/squash-documentation e0b02e72 README.md: document usage of --squash 316cb957 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate 26e2ab10 fix: default boilerplate path 1add8c18 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag 3e811d6c prow.sh: fix "on-master" prow jobs git-subtree-dir: release-tools git-subtree-split: 7bc70e5264a5ce5f47780bdbc6c7b7f4e79243fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed as part of CSI migration. Updated
k8s.io/csi-translation-libto kubernetes-1.14.0 since the latest translation library is depending on k8s v1.14 released staging repok8s.io/apiforLabelZoneFailureDomain.Not sure why there are some behavior change along with the dependency update, so that I have to update a test case to make test happy.
/cc @ddebroy @davidz627 @msau42