Fix #128 - Cannot attach raw block volumes#129
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Mar 5, 2019
Merged
Fix #128 - Cannot attach raw block volumes#129k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
CSI has supported raw block volumes since version 0.1, and Kubernetes since v1.9, but the external-attacher cannot attach a block volume. When attaching a raw block volume we don't even see an error on the external-attacher logs saying it cannot handle it, it just goes ahead assuming it's a mount type of volume. This patch checks the volume mode on the spec to see if it's a raw volume or not. The the volume mode is define and it's PVBlock we'll use the Block access type, in any other case (undefined and Filesystem mode) we'll use the Mount access type.
Contributor
|
/lgtm Thanks for the PR! |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
Thanks for the quick review! |
Collaborator
|
Maybe CSI sanity also needs a test case for this to ensure that volume plugins are correctly checking capabilities cc @bswartz |
Akrog
added a commit
to Akrog/ember-csi
that referenced
this pull request
Mar 8, 2019
This patch adds raw block volume PVCs and Pods to the Kubernetes with CSI v1 example. We will be using our own external attacher since the one upstream doesn't currently support raw block volume attachs. Issue: kubernetes-csi/external-attacher#128 PR: kubernetes-csi/external-attacher#129
pohly
added a commit
to pohly/external-attacher
that referenced
this pull request
Feb 3, 2021
7bc70e52 Merge pull request kubernetes-csi#129 from pohly/squash-documentation e0b02e72 README.md: document usage of --squash 316cb957 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate 26e2ab10 fix: default boilerplate path 1add8c18 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag 3e811d6c prow.sh: fix "on-master" prow jobs git-subtree-dir: release-tools git-subtree-split: 7bc70e5264a5ce5f47780bdbc6c7b7f4e79243fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSI has supported raw block volumes since version 0.1, and Kubernetes
since v1.9, but the external-attacher cannot attach a block volume.
When attaching a raw block volume we don't even see an error on the
external-attacher logs saying it cannot handle it, it just goes ahead
assuming it's a mount type of volume.
This patch checks the volume mode on the spec to see if it's a raw
volume or not.
The the volume mode is define and it's PVBlock we'll use the Block
access type, in any other case (undefined and Filesystem mode) we'll use
the Mount access type.