Skip to content

Use beta API for CSINode #134

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:use-beta-nodeinfo
Mar 29, 2019
Merged

Use beta API for CSINode #134
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:use-beta-nodeinfo

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Mar 28, 2019

Work in progress: contains #133 to get 1.14 API.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from lpabon and msau42 March 28, 2019 12:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2019
@jsafrane jsafrane force-pushed the use-beta-nodeinfo branch from 7c52117 to df8b6b9 Compare March 28, 2019 12:19
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Mar 28, 2019

lgtm
csi-api probably can be removed from vendor too

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Mar 29, 2019

Does the readme need to be updated to say 1.14?

@jsafrane jsafrane force-pushed the use-beta-nodeinfo branch from df8b6b9 to 313ab11 Compare March 29, 2019 10:37
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2019
@jsafrane
Copy link
Copy Markdown
Contributor Author

  • Rebased
  • removed csi-api from vendor
  • bumped min. Kubernetes version in Readme to 1.14

@jsafrane jsafrane changed the title WIP: Use beta API for CSINode Use beta API for CSINode Mar 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2019
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Mar 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3156c24 into kubernetes-csi:master Mar 29, 2019
pohly added a commit to pohly/external-attacher that referenced this pull request Mar 18, 2021
1748b16b Merge pull request kubernetes-csi#136 from pohly/go-1.16
ec844ea6 remove travis.yml, Go 1.16
df76aba8 Merge pull request kubernetes-csi#134 from andyzhangx/add-build-arg
e314a56d add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3

git-subtree-dir: release-tools
git-subtree-split: 1748b16b488381c34a86ddbee110e9ed523bcb20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants