Updated docs for enabling topology#64
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
|
/assign @lpabon |
|
@verult: GitHub didn't allow me to request PR reviews from the following users: xing-yang. Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vladimirvivien
left a comment
vladimirvivien
left a comment
There was a problem hiding this comment.
This looks good. Thanks for correcting my misspells.
| 2) Install the `CSIDriver` CRD on the Kubernetes cluster with the following command: | ||
| ``` | ||
| $> kubectl create -f https://raw.githubusercontent.com/kubernetes/csi-api/master/pkg/crd/testdata/csidriver.yaml | ||
| $> kubectl create -f https://raw.githubusercontent.com/kubernetes/csi-api/master/pkg/crd/testdata/csidriver.yaml --validate=false |
There was a problem hiding this comment.
Thanks for adding this. Missed it.
There was a problem hiding this comment.
We'll should archive all of this after 1.13 as a 1.12 steps and update it for 1.13.
There was a problem hiding this comment.
Yep after 1.13 components roll out we could do another doc pass to make sure everything is updated
book/src/Setup.md
Outdated
| --feature-gates=Topology=true | ||
| ``` | ||
|
|
||
| In addition, in the *Kubernetes cluster* the `CSINodeInfo` alpha feature must be enabled: |
There was a problem hiding this comment.
Add something like (see above for detail about CSINodeInfo)
| In order to support topology-aware dynamic provisioning mechanisms available in Kubernetes, the *external-provisioner* must have the Topology feature enabled: | ||
|
|
||
| ``` | ||
| --feature-gates=Topology=true |
There was a problem hiding this comment.
Im testing topology support using EBS CSI driver, doesn't seem this feature gate is required for me. And this flag is not present in kube_features.go too. Is this a real feature gate?
There was a problem hiding this comment.
This is a provisioner flag
|
@leakingtapan yep sounds good, I just have a couple of comments and I'll cherry-pick your PR after they are addressed |
k8s-ci-robot
added
size/L
|
Updated with @leakingtapan 's changes and addressed comments, PTAL |
|
lgtm |
|
/lgtm |
|
@leakingtapan: changing LGTM is restricted to assignees, and only kubernetes-csi/docs repo collaborators may be assigned issues. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Rebased! |
|
@verult: GitHub didn't allow me to assign the following users: msau42. Note that only kubernetes-csi members and repo collaborators can be assigned. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, verult The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
8 participants
Documentation for kubernetes-csi/external-provisioner#148. Holding until that PR merges
/hold