-
Notifications
You must be signed in to change notification settings - Fork 256
Updated docs for enabling topology #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ If you want to use the `CSIDriver` CRD and get a preview of how configuration wi | |
| 1) Ensure the feature gate is enabled with `--feature-gates=CSIDriverRegistry=true` | ||
| 2) Install the `CSIDriver` CRD on the Kubernetes cluster with the following command: | ||
| ``` | ||
| $> kubectl create -f https://raw.githubusercontent.com/kubernetes/csi-api/master/pkg/crd/testdata/csidriver.yaml | ||
| $> kubectl create -f https://raw.githubusercontent.com/kubernetes/csi-api/master/pkg/crd/testdata/csidriver.yaml --validate=false | ||
| ``` | ||
|
|
||
| ### Listing registered CSI drivers | ||
|
|
@@ -129,16 +129,16 @@ items: | |
| Where: | ||
| - `csiDrivers` - list of CSI drivers running on the node and their properties. | ||
| - `driver` - the CSI driver that this object refers to. | ||
| - `nodeId` - the assigned identifier for the node as determined by the driver. | ||
| - `toplogykeys` - A list of topology keys assigned to the node as supported by the driver. | ||
| - `nodeID` - the assigned identifier for the node as determined by the driver. | ||
| - `topologyKeys` - A list of topology keys assigned to the node as supported by the driver. | ||
|
|
||
| ### Enabling CSINodeInfo | ||
| If you want to use the `CSINodeInfo` CRD and get a preview of how configuration will work at runtime, do the followings: | ||
|
|
||
| 1) Ensure the feature gate is enabled with `--feature-gates=CSIDriverRegistry=true` | ||
| 1) Ensure the feature gate is enabled with `--feature-gates=CSINodeInfo=true` | ||
| 2) Install the `CSINodeInfo` CRD on the Kubernetes cluster with the following command: | ||
| ``` | ||
| $> kubectl create -f https://raw.githubusercontent.com/kubernetes/csi-api/master/pkg/crd/testdata/csinodeinfo.yaml | ||
| $> kubectl create -f https://raw.githubusercontent.com/kubernetes/csi-api/master/pkg/crd/testdata/csinodeinfo.yaml --validate=false | ||
| ``` | ||
|
|
||
|
|
||
|
|
@@ -224,6 +224,20 @@ by default for alpha): | |
| --feature-gates=VolumeSnapshotDataSource=true | ||
| ``` | ||
|
|
||
| ## Topology (alpha) | ||
| In order to support topology-aware dynamic provisioning mechanisms available in Kubernetes, the *external-provisioner* must have the Topology feature enabled: | ||
|
|
||
| ``` | ||
| --feature-gates=Topology=true | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Im testing topology support using EBS CSI driver, doesn't seem this feature gate is required for me. And this flag is not present in kube_features.go too. Is this a real feature gate?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a provisioner flag |
||
| ``` | ||
|
|
||
| In addition, in the *Kubernetes cluster* the `CSINodeInfo` alpha feature must be enabled (refer to the [CSINodeInfo custom resource]{csinodeinfo-custom-resource-alpha} section for more info): | ||
|
|
||
| ``` | ||
| --feature-gates=CSINodeInfo=true | ||
| ``` | ||
| as well as the `KubeletPluginsWatcher` beta feature (currently enabled by default). | ||
|
|
||
| ## Archives | ||
|
|
||
| Please visit the [Archives](Archive.html) for setup instructions on previous versions of Kubernetes. | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Missed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll should archive all of this after 1.13 as a 1.12 steps and update it for 1.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep after 1.13 components roll out we could do another doc pass to make sure everything is updated